mirror of
https://github.com/VictoriaMetrics/VictoriaMetrics.git
synced 2026-05-17 00:26:36 +03:00
06f590ee63
A few users reported unexpected errors when environment variables referred other environment variables
at VictoriaMetrics startup. This resulted in the following fatal error on startup:
cannot expand "..." env var value "...%{SOME_NON_EXISTING_ENV_VAR}..."
Fix this by leaving placeholders with non-existing env vars as is.
This improves the general usability of environment variables by VictoriaMetrics components
inside command-line flags and inside config files. User can easily notice placeholders with non-existing
environment variables by looking at the corresponding command-line flag or at the corresponding config option value.
While at it, replace duplicate docs about environment variables at the https://docs.victoriametrics.com/victoriametrics/cluster-victoriametrics/#environment-variables
with the link to the same docs at https://docs.victoriametrics.com/victoriametrics/single-server-victoriametrics/#environment-variables .
Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3999
82 lines
2.1 KiB
Go
82 lines
2.1 KiB
Go
package envtemplate
|
|
|
|
import (
|
|
"reflect"
|
|
"sort"
|
|
"testing"
|
|
)
|
|
|
|
func TestExpandTemplates(t *testing.T) {
|
|
f := func(envs, resultExpected []string) {
|
|
t.Helper()
|
|
m := parseEnvVars(envs)
|
|
mExpanded := expandTemplates(m)
|
|
result := make([]string, 0, len(mExpanded))
|
|
for k, v := range mExpanded {
|
|
result = append(result, k+"="+v)
|
|
}
|
|
sort.Strings(result)
|
|
if !reflect.DeepEqual(result, resultExpected) {
|
|
t.Fatalf("unexpected result;\ngot\n%q\nwant\n%q", result, resultExpected)
|
|
}
|
|
}
|
|
f(nil, []string{})
|
|
f([]string{"foo=%{bar}", "bar=x"}, []string{"bar=x", "foo=x"})
|
|
f([]string{"a=x%{b}", "b=y%{c}z%{d}", "c=123", "d=qwe"}, []string{"a=xy123zqwe", "b=y123zqwe", "c=123", "d=qwe"})
|
|
f([]string{"a=x%{b}y", "b=z%{a}q", "c"}, []string{"a=xzxzxzxz%{a}qyqyqyqy", "b=zxzxzxzx%{b}yqyqyqyq", "c="})
|
|
f([]string{"a=%{x.y}", "x.y=test"}, []string{"a=test", "x.y=test"})
|
|
f([]string{"a=%{x y}"}, []string{"a=%{x y}"})
|
|
f([]string{"a=%{123}"}, []string{"a=%{123}"})
|
|
}
|
|
|
|
func TestLookupEnv(t *testing.T) {
|
|
envVars = map[string]string{
|
|
"foo": "bar",
|
|
}
|
|
result, ok := LookupEnv("foo")
|
|
if result != "bar" {
|
|
t.Fatalf("unexpected result; got %q; want %q", result, "bar")
|
|
}
|
|
if !ok {
|
|
t.Fatalf("unexpected ok=false")
|
|
}
|
|
result, ok = LookupEnv("bar")
|
|
if result != "" {
|
|
t.Fatalf("unexpected non-empty result: %q", result)
|
|
}
|
|
if ok {
|
|
t.Fatalf("unexpected ok=true")
|
|
}
|
|
}
|
|
|
|
func TestReplaceSuccess(t *testing.T) {
|
|
envVars = map[string]string{
|
|
"foo": "bar",
|
|
"foo.bar_1": "baz",
|
|
"foo-bar_2": "test",
|
|
}
|
|
f := func(s, resultExpected string) {
|
|
t.Helper()
|
|
result := ReplaceBytes([]byte(s))
|
|
if string(result) != resultExpected {
|
|
t.Fatalf("unexpected result for ReplaceBytes(%q);\ngot\n%q\nwant\n%q", s, result, resultExpected)
|
|
}
|
|
resultS := ReplaceString(s)
|
|
if resultS != resultExpected {
|
|
t.Fatalf("unexpected result for ReplaceString(%q);\ngot\n%q\nwant\n%q", s, result, resultExpected)
|
|
}
|
|
}
|
|
|
|
// Zero placeholders
|
|
f("", "")
|
|
f("foo", "foo")
|
|
|
|
// Matching placeholders
|
|
f("a %{foo}-x", "a bar-x")
|
|
f("%{foo.bar_1}", "baz")
|
|
f("qq.%{foo-bar_2}.ww", "qq.test.ww")
|
|
|
|
// Missing placeholders
|
|
f("foo %{bar} %{baz} %{foo}", "foo %{bar} %{baz} bar")
|
|
}
|