mirror of
https://github.com/VictoriaMetrics/VictoriaMetrics.git
synced 2026-05-17 00:26:36 +03:00
Proxy protocol parser kept sub-slice reference for pooled bytesBuffer at readProxyProto ``` bb := bbPool.Get() defer bbPool.Put(bb) // ← buffer returned to pool AFTER function returns ... IP: bb.B[0:16], // ← BUG: sub-slice of pooled buffer! ... ``` This commit properly allocates new slice for ipv6 address and copies buffer content to it. Fixes https://github.com/VictoriaMetrics/VictoriaMetrics/issues/10839
149 lines
4.3 KiB
Go
149 lines
4.3 KiB
Go
package netutil
|
|
|
|
import (
|
|
"encoding/binary"
|
|
"errors"
|
|
"fmt"
|
|
"io"
|
|
"net"
|
|
"sync"
|
|
|
|
"github.com/VictoriaMetrics/VictoriaMetrics/lib/bytesutil"
|
|
)
|
|
|
|
type proxyProtocolConn struct {
|
|
net.Conn
|
|
once sync.Once
|
|
remoteAddr net.Addr
|
|
readErr error
|
|
}
|
|
|
|
func newProxyProtocolConn(c net.Conn) net.Conn {
|
|
return &proxyProtocolConn{
|
|
Conn: c,
|
|
}
|
|
}
|
|
|
|
func (ppc *proxyProtocolConn) init() {
|
|
ppc.once.Do(func() {
|
|
addr, err := readProxyProto(ppc.Conn)
|
|
if err != nil {
|
|
if !errors.Is(err, io.EOF) {
|
|
proxyProtocolReadErrorLogger.Errorf("cannot read proxy proto conn for TCP addr %q: %s", ppc.Conn.RemoteAddr(), err)
|
|
}
|
|
ppc.readErr = err
|
|
return
|
|
}
|
|
if addr == nil {
|
|
addr = ppc.Conn.RemoteAddr()
|
|
}
|
|
ppc.remoteAddr = addr
|
|
})
|
|
}
|
|
|
|
func (ppc *proxyProtocolConn) Read(p []byte) (int, error) {
|
|
ppc.init()
|
|
if ppc.readErr != nil {
|
|
return 0, ppc.readErr
|
|
}
|
|
return ppc.Conn.Read(p)
|
|
}
|
|
|
|
func (ppc *proxyProtocolConn) RemoteAddr() net.Addr {
|
|
ppc.init()
|
|
if ppc.readErr != nil {
|
|
return ppc.Conn.RemoteAddr()
|
|
}
|
|
return ppc.remoteAddr
|
|
}
|
|
|
|
func readProxyProto(r io.Reader) (net.Addr, error) {
|
|
bb := bbPool.Get()
|
|
defer bbPool.Put(bb)
|
|
|
|
// Read the first 16 bytes of proxy protocol header:
|
|
// - bytes 0-11: v2Identifier
|
|
// - byte 12: version and command
|
|
// - byte 13: family and protocol
|
|
// - bytes 14-15: payload length
|
|
//
|
|
// See https://www.haproxy.org/download/1.8/doc/proxy-protocol.txt
|
|
bb.B = bytesutil.ResizeNoCopyMayOverallocate(bb.B, 16)
|
|
if _, err := io.ReadFull(r, bb.B); err != nil {
|
|
return nil, fmt.Errorf("cannot read proxy protocol header: %w", err)
|
|
}
|
|
ident := bb.B[:12]
|
|
if string(ident) != v2Identifier {
|
|
return nil, fmt.Errorf("unexpected proxy protocol header: %q; want %q", ident, v2Identifier)
|
|
}
|
|
version := bb.B[12] >> 4
|
|
command := bb.B[12] & 0x0f
|
|
family := bb.B[13] >> 4
|
|
proto := bb.B[13] & 0x0f
|
|
if version != 2 {
|
|
return nil, fmt.Errorf("unsupported proxy protocol version, only v2 protocol version is supported, got: %d", version)
|
|
}
|
|
// check for supported proto:
|
|
switch {
|
|
case proto == 0 && command == 0:
|
|
// 0 - UNSPEC with LOCAL command 0. Common use case for load balancer health checks.
|
|
case proto == 1:
|
|
// 1 - TCP (aka STREAM).
|
|
default:
|
|
return nil, fmt.Errorf("the proxy protocol implementation doesn't support proto %d and command: %d; expecting proto 1 or proto 0 with command 0", proto, command)
|
|
}
|
|
// The length of the remainder of the header including any TLVs in network byte order
|
|
// 0, 1, 2
|
|
blockLen := int(binary.BigEndian.Uint16(bb.B[14:16]))
|
|
// in general RFC doesn't limit block length, but for sanity check lets limit it to 2kb
|
|
// in theory TLVs may occupy some space
|
|
if blockLen > 2048 {
|
|
return nil, fmt.Errorf("too big proxy protocol block length: %d; it mustn't exceed 2048 bytes", blockLen)
|
|
}
|
|
|
|
// Read the protocol block itself
|
|
bb.B = bytesutil.ResizeNoCopyMayOverallocate(bb.B, blockLen)
|
|
if _, err := io.ReadFull(r, bb.B); err != nil {
|
|
return nil, fmt.Errorf("cannot read proxy protocol block with the length %d bytes: %w", blockLen, err)
|
|
}
|
|
switch command {
|
|
case 0:
|
|
// Proxy LOCAL command. Ignore the protocol block. The real sender address should be used.
|
|
return nil, nil
|
|
case 1:
|
|
// Parse the protocol block according to the family.
|
|
switch family {
|
|
case 1:
|
|
// ipv4 (aka AF_INET)
|
|
if len(bb.B) < 12 {
|
|
return nil, fmt.Errorf("cannot read ipv4 address from proxy protocol block with the length %d bytes; expected at least 12 bytes", len(bb.B))
|
|
}
|
|
remoteAddr := &net.TCPAddr{
|
|
IP: net.IPv4(bb.B[0], bb.B[1], bb.B[2], bb.B[3]),
|
|
Port: int(binary.BigEndian.Uint16(bb.B[8:10])),
|
|
}
|
|
return remoteAddr, nil
|
|
case 2:
|
|
// ipv6 (aka AF_INET6)
|
|
if len(bb.B) < 36 {
|
|
return nil, fmt.Errorf("cannot read ipv6 address from proxy protocol block with the length %d bytes; expected at least 36 bytes", len(bb.B))
|
|
}
|
|
var ipv6Addr net.IP
|
|
ipv6Addr = append(ipv6Addr, bb.B[:16]...)
|
|
remoteAddr := &net.TCPAddr{
|
|
IP: ipv6Addr,
|
|
Port: int(binary.BigEndian.Uint16(bb.B[32:34])),
|
|
}
|
|
return remoteAddr, nil
|
|
default:
|
|
return nil, fmt.Errorf("the proxy protocol implementation doesn't support protocol family %d; supported values: 1, 2", family)
|
|
}
|
|
default:
|
|
return nil, fmt.Errorf("the proxy protocol implementation doesn't support command %d; supported values: 0, 1", command)
|
|
}
|
|
}
|
|
|
|
const v2Identifier = "\r\n\r\n\x00\r\nQUIT\n"
|
|
|
|
var bbPool bytesutil.ByteBufferPool
|