30b9167965
### Describe Your Changes Add cluster replication tests. No group replication yet. Some necessary enhancements to the apptest framework have been done as well. Also other existing tests were revisitied to take advantage of new QueryOpts added by @f41gh7 in #7635. The tests verify the following scenarios: 1. Data is written to vmstorages multiple times 2. Vmselect deduplicates replicated data 3. Vmselect does not return partial result if it receives responses from enough replicas 4. Vmselect does not wait for the rest from all replicas (skips slower ones) Something similar will be added for storage groups. These tests should be used to prove that the fix for #6924 works and at the same time does not break other aspects of replication. ### Checklist The following checks are **mandatory**: - [x] My change adheres [VictoriaMetrics contributing guidelines](https://docs.victoriametrics.com/contributing/). --------- Signed-off-by: Artem Fetishev <rtm@victoriametrics.com>
App Integration Tests
The apptest package contains the integration tests for the VictoriaMetrics
applications (such as vmstorage, vminsert, and vmselect).
An integration test aims at verifying the behavior of an application as a whole, as apposed to a unit test that verifies the behavior of a building block of an application.
To achieve that an integration test starts an application in a separate process and then issues HTTP requets to it and verifies the responses, examines the metrics the app exposes and/or files it creates, etc.
Note that an object of testing may be not just a single app, but several apps working together. A good example is VictoriaMetrics cluster. An integration test may reproduce an arbitrary cluster configuration and verify how the components work together as a system.
The package provides a collection of helpers to start applications and make queries to them:
app.go- contains the generic code for staring an application and should not be used by integration tests directly.{vmstorage,vminsert,etc}.go- build on top ofapp.goand provide the code for staring a specific application.client.go- provides helper functions for sending HTTP requests to applications.
The integration tests themselves reside in tests/*_test.go files. Apart from having
the _test suffix, there are no strict rules of how to name a file, but the
name should reflect the prevailing purpose of the tests located in that file.
For example, sharding_test.go aims at testing data sharding.
Since integration tests start applications in a separate process, they require
the application binary files to be built and put into the bin directory. The
build rule used for running integration tests, make integration-test,
accounts for that, it builds all application binaries before running the tests.
But if you want to run the tests without make, i.e. by executing
go test ./app/apptest, you will need to build the binaries first (for example,
by executing make all).
Not all binaries can be built from master branch, cluster binaries can be built
only from cluster branch. Hence, not all test cases suitable to run in both branches:
- If test is using binaries from
clusterbranch, then test name should be prefixed withTestClusterword - If test is using binaries from
masterbranch, then test name should be prefixed withTestVmsingleword.