rms/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2026-05-17 08:36:55 +03:00
Code Issues Packages Projects Releases Wiki Activity

lib: consistently use logger.Panicf("BUG: ...") for logging programming bugs

Browse Source 
logger.Fatalf("BUG: ...") complicates investigating the bug, since it doesn't show the call stack,
which led to the bug. So it is better to consistently use logger.Panicf("BUG: ...") for logging programming bugs.
This commit is contained in:
Aliaksandr Valialkin
2025-01-24 16:35:07 +01:00
parent 026894054b
commit 467cdd8a3d
4 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/fs/fs_windows.go
View File

@@ -98,7 +98,7 @@ func mUnmap(data []byte) error {
mmapByAddrLock.Lock()
h, ok := mmapByAddr[addr]
if !ok {
logger.Fatalf("BUG: unmapping for non exist addr: %d", addr)
logger.Panicf("BUG: unmapping for non exist addr: %d", addr)
}
delete(mmapByAddr, addr)
mmapByAddrLock.Unlock()

8
lib/logstorage/parser.go
View File

@@ -808,7 +808,7 @@ func flattenFiltersAnd(f filter) filter {
}
f, err := copyFilter(f, visitFunc, copyFunc)
if err != nil {
logger.Fatalf("BUG: unexpected error: %s", err)
logger.Panicf("BUG: unexpected error: %s", err)
}
return f
}
@@ -844,7 +844,7 @@ func flattenFiltersOr(f filter) filter {
}
f, err := copyFilter(f, visitFunc, copyFunc)
if err != nil {
logger.Fatalf("BUG: unexpected error: %s", err)
logger.Panicf("BUG: unexpected error: %s", err)
}
return f
}
@@ -861,7 +861,7 @@ func removeStarFilters(f filter) filter {
}
f, err := copyFilter(f, visitFunc, copyFunc)
if err != nil {
logger.Fatalf("BUG: unexpected error: %s", err)
logger.Panicf("BUG: unexpected error: %s", err)
}
// Drop filterNoop inside filterAnd
@@ -897,7 +897,7 @@ func removeStarFilters(f filter) filter {
}
f, err = copyFilter(f, visitFunc, copyFunc)
if err != nil {
logger.Fatalf("BUG: unexpected error: %s", err)
logger.Panicf("BUG: unexpected error: %s", err)
}
return f

2
lib/persistentqueue/fastqueue.go
View File

@@ -162,7 +162,7 @@ func (fq *FastQueue) GetInmemoryQueueLen() int {
// This method allows perisisting in-memory blocks during graceful shutdown, even if persistence is disabled.
func (fq *FastQueue) MustWriteBlockIgnoreDisabledPQ(block []byte) {
if !fq.tryWriteBlock(block, true) {
logger.Fatalf("BUG: tryWriteBlock must always write data even if persistence is disabled")
logger.Panicf("BUG: tryWriteBlock must always write data even if persistence is disabled")
}
}

2
lib/promscrape/discovery/digitalocean/digitalocean.go
View File

@@ -75,7 +75,7 @@ func (d *droplet) getIPByNet(netVersion, netType string) string {
case "v6":
dropletNetworks = d.Networks.V6
default:
logger.Fatalf("BUG, unexpected network type: %s, want v4 or v6", netVersion)
logger.Panicf("BUG: unexpected network type: %s, want v4 or v6", netVersion)
}
for _, net := range dropletNetworks {
if net.Type == netType {