update

.golangci.yml

@@ -1,9 +1,15 @@
 version: "2"
 linters:
+  enable:
+    - errorlint
   settings:
     errcheck:
       exclude-functions:
         - (net/http.ResponseWriter).Write
+    errorlint:
+      errorf: true
+      comparison: false
+      asserts: false
   exclusions:
     generated: lax
     presets:

app/vmagent/main.go

@@ -462,9 +462,7 @@ func requestHandler(w http.ResponseWriter, r *http.Request) bool {
 		return true
 	case "/prometheus/metric-relabel-debug", "/metric-relabel-debug":
 		promscrapeMetricRelabelDebugRequests.Inc()
-		rwGlobalRelabelConfigs := remotewrite.GetRemoteWriteRelabelConfigString()
-		rwURLRelabelConfigss := remotewrite.GetURLRelabelConfigString()
-		promscrape.WriteMetricRelabelDebug(w, r, rwGlobalRelabelConfigs, rwURLRelabelConfigss)
+		promscrape.WriteMetricRelabelDebug(w, r)
 		return true
 	case "/prometheus/target-relabel-debug", "/target-relabel-debug":
 		promscrapeTargetRelabelDebugRequests.Inc()

app/vmagent/remotewrite/relabel.go

@@ -12,7 +12,6 @@ import (
 	"github.com/VictoriaMetrics/metrics"
 	"gopkg.in/yaml.v2"
 
-	"github.com/VictoriaMetrics/VictoriaMetrics/lib/bytesutil"
 	"github.com/VictoriaMetrics/VictoriaMetrics/lib/fasttime"
 	"github.com/VictoriaMetrics/VictoriaMetrics/lib/flagutil"
 	"github.com/VictoriaMetrics/VictoriaMetrics/lib/logger"
@@ -83,76 +82,30 @@ func WriteRelabelConfigData(w io.Writer) {
 	_, _ = w.Write(*p)
 }
 
-// GetRemoteWriteRelabelConfigString returns -remoteWrite.relabelConfig contents in string
-func GetRemoteWriteRelabelConfigString() string {
-	var bb bytesutil.ByteBuffer
-	WriteRelabelConfigData(&bb)
-	if bb.Len() == 0 {
-		return ""
-	}
-	return string(bb.B)
-}
-
-type UrlRelabelCfg struct {
-	Url           string `yaml:"url"`
-	RelabelConfig any    `yaml:"relabel_config"`
-
-	RelabelConfigStr string
-}
-
 // WriteURLRelabelConfigData writes -remoteWrite.urlRelabelConfig contents to w
 func WriteURLRelabelConfigData(w io.Writer) {
-	cs := GetURLRelabelConfigData()
-	if cs == nil {
+	p := remoteWriteURLRelabelConfigData.Load()
+	if p == nil {
 		// Nothing to write to w
 		return
 	}
-	d, _ := yaml.Marshal(cs)
-	_, _ = w.Write(d)
-}
-
-// GetURLRelabelConfigData is similar to WriteURLRelabelConfigData but returning data in []UrlRelabelCfg.
-func GetURLRelabelConfigData() []UrlRelabelCfg {
-	p := remoteWriteURLRelabelConfigData.Load()
-	if p == nil {
-		return nil
+	type urlRelabelCfg struct {
+		Url           string `yaml:"url"`
+		RelabelConfig any    `yaml:"relabel_config"`
 	}
-	var cs []UrlRelabelCfg
+	var cs []urlRelabelCfg
 	for i, url := range *remoteWriteURLs {
 		cfgData := (*p)[i]
-		var cfgDataBytes []byte
-		if cfgData != nil {
-			cfgDataBytes, _ = yaml.Marshal(cfgData)
-		}
 		if !*showRemoteWriteURL {
 			url = fmt.Sprintf("%d:secret-url", i+1)
 		}
-		cs = append(cs, UrlRelabelCfg{
+		cs = append(cs, urlRelabelCfg{
 			Url:           url,
 			RelabelConfig: cfgData,
-
-			RelabelConfigStr: string(cfgDataBytes),
 		})
 	}
-	return cs
-}
-
-// GetURLRelabelConfigString returns -remoteWrite.urlRelabelConfig contents in []string
-func GetURLRelabelConfigString() []string {
-	p := remoteWriteURLRelabelConfigData.Load()
-	if p == nil {
-		return nil
-	}
-	var ss []string
-	for i := range *remoteWriteURLs {
-		cfgData := (*p)[i]
-		var cfgDataBytes []byte
-		if cfgData != nil {
-			cfgDataBytes, _ = yaml.Marshal(cfgData)
-		}
-		ss = append(ss, string(cfgDataBytes))
-	}
-	return ss
+	d, _ := yaml.Marshal(cs)
+	_, _ = w.Write(d)
 }
 
 func reloadRelabelConfigs() {

app/vmctl/utils.go

@@ -74,9 +74,9 @@ func wrapErr(vmErr *vm.ImportError, verbose bool) error {
 		verboseMsg = "(enable `--verbose` output to get more details)"
 	}
 	if vmErr.Err == nil {
-		return fmt.Errorf("%s\n\tLatest delivered batch for timestamps range %d - %d %s\n%s",
+		return fmt.Errorf("%w\n\tLatest delivered batch for timestamps range %d - %d %s\n%s",
 			vmErr.Err, minTS, maxTS, verboseMsg, errTS)
 	}
-	return fmt.Errorf("%s\n\tImporting batch failed for timestamps range %d - %d %s\n%s",
+	return fmt.Errorf("%w\n\tImporting batch failed for timestamps range %d - %d %s\n%s",
 		vmErr.Err, minTS, maxTS, verboseMsg, errTS)
 }

app/vmselect/main.go

@@ -538,7 +538,7 @@ func handleStaticAndSimpleRequests(w http.ResponseWriter, r *http.Request, path
 		return true
 	case "/metric-relabel-debug":
 		promscrapeMetricRelabelDebugRequests.Inc()
-		promscrape.WriteMetricRelabelDebug(w, r, "", nil)
+		promscrape.WriteMetricRelabelDebug(w, r)
 		return true
 	case "/target-relabel-debug":
 		promscrapeTargetRelabelDebugRequests.Inc()

apptest/client.go

@@ -156,14 +156,14 @@ func readAllAndClose(t *testing.T, responseBody io.ReadCloser) string {
 //
 // This type is expected to be embedded by the apps that serve metrics.
 type metricsClient struct {
-	cli *Client
-	url string
+	metricsCli *Client
+	url        string
 }
 
 func newMetricsClient(cli *Client, addr string) *metricsClient {
 	return &metricsClient{
-		cli: cli,
-		url: fmt.Sprintf("http://%s/metrics", addr),
+		metricsCli: cli,
+		url:        fmt.Sprintf("http://%s/metrics", addr),
 	}
 }
 
@@ -179,7 +179,7 @@ func (c *metricsClient) GetIntMetric(t *testing.T, metricName string) int {
 func (c *metricsClient) GetMetric(t *testing.T, metricName string) float64 {
 	t.Helper()
 
-	metrics, statusCode := c.cli.Get(t, c.url, nil)
+	metrics, statusCode := c.metricsCli.Get(t, c.url, nil)
 	if statusCode != http.StatusOK {
 		t.Fatalf("unexpected status code: got %d, want %d", statusCode, http.StatusOK)
 	}
@@ -205,7 +205,7 @@ func (c *metricsClient) GetMetricsByPrefix(t *testing.T, prefix string) []float6
 
 	values := []float64{}
 
-	metrics, statusCode := c.cli.Get(t, c.url, nil)
+	metrics, statusCode := c.metricsCli.Get(t, c.url, nil)
 	if statusCode != http.StatusOK {
 		t.Fatalf("unexpected status code: got %d, want %d", statusCode, http.StatusOK)
 	}
@@ -234,7 +234,7 @@ func (c *metricsClient) GetMetricsByRegexp(t *testing.T, re *regexp.Regexp) []fl
 
 	values := []float64{}
 
-	metrics, statusCode := c.cli.Get(t, c.url, nil)
+	metrics, statusCode := c.metricsCli.Get(t, c.url, nil)
 	if statusCode != http.StatusOK {
 		t.Fatalf("unexpected status code: got %d, want %d", statusCode, http.StatusOK)
 	}
@@ -270,7 +270,7 @@ func (c *metricsClient) rpcRowsSentTotal(t *testing.T) int {
 }
 
 type vmselectClient struct {
-	cli                      *Client
+	vmselectCli              *Client
 	url                      func(op, path string, opts QueryOpts) string
 	metricNamesStatsResetURL string
 	tenantsURL               string
@@ -287,7 +287,7 @@ func (c *vmselectClient) PrometheusAPIV1Export(t *testing.T, query string, opts
 	values := opts.asURLValues()
 	values.Add("match[]", query)
 	values.Add("format", "promapi")
-	res, _ := c.cli.PostForm(t, url, values, opts.Headers)
+	res, _ := c.vmselectCli.PostForm(t, url, values, opts.Headers)
 	return NewPrometheusAPIV1QueryResponse(t, res)
 }
 
@@ -302,7 +302,7 @@ func (c *vmselectClient) PrometheusAPIV1ExportNative(t *testing.T, query string,
 	values := opts.asURLValues()
 	values.Add("match[]", query)
 	values.Add("format", "promapi")
-	res, _ := c.cli.PostForm(t, url, values, opts.Headers)
+	res, _ := c.vmselectCli.PostForm(t, url, values, opts.Headers)
 	return []byte(res)
 }
 
@@ -315,7 +315,7 @@ func (c *vmselectClient) PrometheusAPIV1Query(t *testing.T, query string, opts Q
 	url := c.url("select", "prometheus/api/v1/query", opts)
 	values := opts.asURLValues()
 	values.Add("query", query)
-	res, _ := c.cli.PostForm(t, url, values, opts.Headers)
+	res, _ := c.vmselectCli.PostForm(t, url, values, opts.Headers)
 	return NewPrometheusAPIV1QueryResponse(t, res)
 }
 
@@ -329,7 +329,7 @@ func (c *vmselectClient) PrometheusAPIV1QueryRange(t *testing.T, query string, o
 	url := c.url("select", "prometheus/api/v1/query_range", opts)
 	values := opts.asURLValues()
 	values.Add("query", query)
-	res, _ := c.cli.PostForm(t, url, values, opts.Headers)
+	res, _ := c.vmselectCli.PostForm(t, url, values, opts.Headers)
 	return NewPrometheusAPIV1QueryResponse(t, res)
 }
 
@@ -342,7 +342,7 @@ func (c *vmselectClient) PrometheusAPIV1Series(t *testing.T, matchQuery string,
 	url := c.url("select", "prometheus/api/v1/series", opts)
 	values := opts.asURLValues()
 	values.Add("match[]", matchQuery)
-	res, _ := c.cli.PostForm(t, url, values, opts.Headers)
+	res, _ := c.vmselectCli.PostForm(t, url, values, opts.Headers)
 	return NewPrometheusAPIV1SeriesResponse(t, res)
 }
 
@@ -354,7 +354,7 @@ func (c *vmselectClient) PrometheusAPIV1SeriesCount(t *testing.T, opts QueryOpts
 	t.Helper()
 	url := c.url("select", "prometheus/api/v1/series/count", opts)
 	values := opts.asURLValues()
-	res, _ := c.cli.PostForm(t, url, values, opts.Headers)
+	res, _ := c.vmselectCli.PostForm(t, url, values, opts.Headers)
 	return NewPrometheusAPIV1SeriesCountResponse(t, res)
 }
 
@@ -367,7 +367,7 @@ func (c *vmselectClient) PrometheusAPIV1Labels(t *testing.T, matchQuery string,
 	url := c.url("select", "prometheus/api/v1/labels", opts)
 	values := opts.asURLValues()
 	values.Add("match[]", matchQuery)
-	res, _ := c.cli.PostForm(t, url, values, opts.Headers)
+	res, _ := c.vmselectCli.PostForm(t, url, values, opts.Headers)
 	return NewPrometheusAPIV1LabelsResponse(t, res)
 }
 
@@ -382,7 +382,7 @@ func (c *vmselectClient) PrometheusAPIV1LabelValues(t *testing.T, labelName, mat
 	url := c.url("select", path, opts)
 	values := opts.asURLValues()
 	values.Add("match[]", matchQuery)
-	res, _ := c.cli.PostForm(t, url, values, opts.Headers)
+	res, _ := c.vmselectCli.PostForm(t, url, values, opts.Headers)
 	return NewPrometheusAPIV1LabelValuesResponse(t, res)
 }
 
@@ -394,7 +394,7 @@ func (c *vmselectClient) PrometheusAPIV1Metadata(t *testing.T, metric string, li
 	values := opts.asURLValues()
 	values.Add("metric", metric)
 	values.Add("limit", strconv.Itoa(limit))
-	res, _ := c.cli.PostForm(t, url, values, opts.Headers)
+	res, _ := c.vmselectCli.PostForm(t, url, values, opts.Headers)
 	return NewPrometheusAPIV1Metadata(t, res)
 }
 
@@ -408,7 +408,7 @@ func (c *vmselectClient) PrometheusAPIV1AdminTSDBDeleteSeries(t *testing.T, matc
 	url := c.url("delete", "prometheus/api/v1/admin/tsdb/delete_series", opts)
 	values := opts.asURLValues()
 	values.Add("match[]", matchQuery)
-	res, statusCode := c.cli.PostForm(t, url, values, opts.Headers)
+	res, statusCode := c.vmselectCli.PostForm(t, url, values, opts.Headers)
 	if statusCode != http.StatusNoContent {
 		t.Fatalf("unexpected status code: got %d, want %d, resp text=%q", statusCode, http.StatusNoContent, res)
 	}
@@ -426,7 +426,7 @@ func (c *vmselectClient) PrometheusAPIV1StatusMetricNamesStats(t *testing.T, lim
 	values.Add("limit", limit)
 	values.Add("le", le)
 	values.Add("match_pattern", matchPattern)
-	res, statusCode := c.cli.PostForm(t, url, values, opts.Headers)
+	res, statusCode := c.vmselectCli.PostForm(t, url, values, opts.Headers)
 	if statusCode != http.StatusOK {
 		t.Fatalf("unexpected status code: got %d, want %d, resp text=%q", statusCode, http.StatusOK, res)
 	}
@@ -455,7 +455,7 @@ func (c *vmselectClient) PrometheusAPIV1StatusTSDB(t *testing.T, matchQuery stri
 	addNonEmpty("match[]", matchQuery)
 	addNonEmpty("topN", topN)
 	addNonEmpty("date", date)
-	res, statusCode := c.cli.PostForm(t, url, values, opts.Headers)
+	res, statusCode := c.vmselectCli.PostForm(t, url, values, opts.Headers)
 	if statusCode != http.StatusOK {
 		t.Fatalf("unexpected status code: got %d, want %d, resp text=%q", statusCode, http.StatusOK, res)
 	}
@@ -476,7 +476,7 @@ func (c *vmselectClient) GraphiteMetricsIndex(t *testing.T, opts QueryOpts) Grap
 	t.Helper()
 
 	url := c.url("select", "graphite/metrics/index.json", opts)
-	res, statusCode := c.cli.Get(t, url, opts.Headers)
+	res, statusCode := c.vmselectCli.Get(t, url, opts.Headers)
 	if statusCode != http.StatusOK {
 		t.Fatalf("unexpected status code: got %d, want %d, resp text=%q", statusCode, http.StatusOK, res)
 	}
@@ -499,7 +499,7 @@ func (c *vmselectClient) GraphiteMetricsFind(t *testing.T, query string, opts Qu
 	url := c.url("select", "graphite/metrics/find", opts)
 	values := opts.asURLValues()
 	values.Add("query", query)
-	resText, statusCode := c.cli.PostForm(t, url, values, opts.Headers)
+	resText, statusCode := c.vmselectCli.PostForm(t, url, values, opts.Headers)
 	if statusCode != http.StatusOK {
 		t.Fatalf("unexpected status code: got %d, want %d, resp text=%q", statusCode, http.StatusOK, resText)
 	}
@@ -522,7 +522,7 @@ func (c *vmselectClient) GraphiteMetricsExpand(t *testing.T, query string, opts
 	url := c.url("select", "graphite/metrics/expand", opts)
 	values := opts.asURLValues()
 	values.Add("query", query)
-	resText, statusCode := c.cli.PostForm(t, url, values, opts.Headers)
+	resText, statusCode := c.vmselectCli.PostForm(t, url, values, opts.Headers)
 	if statusCode != http.StatusOK {
 		t.Fatalf("unexpected status code: got %d, want %d, resp text=%q", statusCode, http.StatusOK, resText)
 	}
@@ -546,7 +546,7 @@ func (c *vmselectClient) GraphiteRender(t *testing.T, target string, opts QueryO
 	values := opts.asURLValues()
 	values.Add("format", "json")
 	values.Add("target", target)
-	resText, statusCode := c.cli.PostForm(t, url, values, opts.Headers)
+	resText, statusCode := c.vmselectCli.PostForm(t, url, values, opts.Headers)
 	if statusCode != http.StatusOK {
 		t.Fatalf("unexpected status code: got %d, want %d, resp text=%q", statusCode, http.StatusOK, resText)
 	}
@@ -567,7 +567,7 @@ func (c *vmselectClient) GraphiteTagsTagSeries(t *testing.T, record string, opts
 	url := c.url("select", "graphite/tags/tagSeries", opts)
 	values := opts.asURLValues()
 	values.Add("path", record)
-	_, statusCode := c.cli.PostForm(t, url, values, opts.Headers)
+	_, statusCode := c.vmselectCli.PostForm(t, url, values, opts.Headers)
 	if got, want := statusCode, http.StatusNotImplemented; got != want {
 		t.Fatalf("unexpected status code: got %d, want %d", got, want)
 	}
@@ -584,7 +584,7 @@ func (c *vmselectClient) GraphiteTagsTagMultiSeries(t *testing.T, records []stri
 	for _, rec := range records {
 		values.Add("path", rec)
 	}
-	_, statusCode := c.cli.PostForm(t, url, values, opts.Headers)
+	_, statusCode := c.vmselectCli.PostForm(t, url, values, opts.Headers)
 	if got, want := statusCode, http.StatusNotImplemented; got != want {
 		t.Fatalf("unexpected status code: got %d, want %d", got, want)
 	}
@@ -598,7 +598,7 @@ func (c *vmselectClient) GraphiteTagsTagMultiSeries(t *testing.T, records []stri
 func (c *vmselectClient) PrometheusAPIV1AdminStatusMetricNamesStatsReset(t *testing.T, opts QueryOpts) {
 	t.Helper()
 	values := opts.asURLValues()
-	res, statusCode := c.cli.PostForm(t, c.metricNamesStatsResetURL, values, opts.Headers)
+	res, statusCode := c.vmselectCli.PostForm(t, c.metricNamesStatsResetURL, values, opts.Headers)
 	if statusCode != http.StatusNoContent {
 		t.Fatalf("unexpected status code: got %d, want %d, resp text=%q", statusCode, http.StatusNoContent, res)
 	}
@@ -608,7 +608,7 @@ func (c *vmselectClient) PrometheusAPIV1AdminStatusMetricNamesStatsReset(t *test
 // /admin/tenants endpoint.
 func (c *vmselectClient) APIV1AdminTenants(t *testing.T, opts QueryOpts) *AdminTenantsResponse {
 	t.Helper()
-	res, statusCode := c.cli.Get(t, c.tenantsURL, opts.Headers)
+	res, statusCode := c.vmselectCli.Get(t, c.tenantsURL, opts.Headers)
 	if statusCode != http.StatusOK {
 		t.Fatalf("unexpected status code: got %d, want %d, resp text=%q", statusCode, http.StatusOK, res)
 	}
@@ -622,7 +622,7 @@ func (c *vmselectClient) APIV1AdminTenants(t *testing.T, opts QueryOpts) *AdminT
 }
 
 type vminsertClient struct {
-	cli                *Client
+	vminsertCli        *Client
 	url                func(op, path string, opts QueryOpts) string
 	openTSDBURL        func(op, path string, opts QueryOpts) string
 	graphiteListenAddr string
@@ -647,7 +647,7 @@ func (c *vminsertClient) PrometheusAPIV1ImportCSV(t *testing.T, records []string
 	headers := opts.getHeaders()
 	headers.Set("Content-Type", "text/plain")
 	c.sendBlocking(t, len(records), func() {
-		_, statusCode := c.cli.Post(t, url, data, headers)
+		_, statusCode := c.vminsertCli.Post(t, url, data, headers)
 		if statusCode != http.StatusNoContent {
 			t.Fatalf("unexpected status code: got %d, want %d", statusCode, http.StatusNoContent)
 		}
@@ -671,7 +671,7 @@ func (c *vminsertClient) PrometheusAPIV1ImportNative(t *testing.T, data []byte,
 	headers := opts.getHeaders()
 	headers.Set("Content-Type", "text/plain")
 	c.sendBlocking(t, 1, func() {
-		_, statusCode := c.cli.Post(t, url, data, headers)
+		_, statusCode := c.vminsertCli.Post(t, url, data, headers)
 		if statusCode != http.StatusNoContent {
 			t.Fatalf("unexpected status code: got %d, want %d", statusCode, http.StatusNoContent)
 		}
@@ -693,7 +693,7 @@ func (c *vminsertClient) PrometheusAPIV1Write(t *testing.T, wr prompb.WriteReque
 	headers := opts.getHeaders()
 	headers.Set("Content-Type", "application/x-protobuf")
 	c.sendBlocking(t, recordsCount, func() {
-		_, statusCode := c.cli.Post(t, url, data, headers)
+		_, statusCode := c.vminsertCli.Post(t, url, data, headers)
 		if statusCode != http.StatusNoContent {
 			t.Fatalf("unexpected status code: got %d, want %d", statusCode, http.StatusNoContent)
 		}
@@ -745,7 +745,7 @@ func (c *vminsertClient) PrometheusAPIV1ImportPrometheus(t *testing.T, records [
 	headers := opts.getHeaders()
 	headers.Set("Content-Type", "text/plain")
 	c.sendBlocking(t, recordsCount, func() {
-		_, statusCode := c.cli.Post(t, url, data, headers)
+		_, statusCode := c.vminsertCli.Post(t, url, data, headers)
 		if statusCode != http.StatusNoContent {
 			t.Fatalf("unexpected status code: got %d, want %d", statusCode, http.StatusNoContent)
 		}
@@ -771,7 +771,7 @@ func (c *vminsertClient) InfluxWrite(t *testing.T, records []string, opts QueryO
 	headers.Set("Content-Type", "text/plain")
 	c.sendBlocking(t, len(records), func() {
 		t.Helper()
-		_, statusCode := c.cli.Post(t, url, data, headers)
+		_, statusCode := c.vminsertCli.Post(t, url, data, headers)
 		if statusCode != http.StatusNoContent {
 			t.Fatalf("unexpected status code: got %d, want %d", statusCode, http.StatusNoContent)
 		}
@@ -805,7 +805,7 @@ func (c *vminsertClient) OpentelemetryV1Metrics(t *testing.T, md otlppb.MetricsD
 	headers := opts.getHeaders()
 	headers.Set("Content-Type", "application/x-protobuf")
 	c.sendBlocking(t, recordsCount, func() {
-		_, statusCode := c.cli.Post(t, url, data, headers)
+		_, statusCode := c.vminsertCli.Post(t, url, data, headers)
 		if statusCode != http.StatusOK {
 			t.Fatalf("unexpected status code: got %d, want %d", statusCode, http.StatusOK)
 		}
@@ -830,7 +830,7 @@ func (c *vminsertClient) OpenTSDBAPIPut(t *testing.T, records []string, opts Que
 	headers := opts.getHeaders()
 	headers.Set("Content-Type", "application/json")
 	c.sendBlocking(t, len(records), func() {
-		_, statusCode := c.cli.Post(t, url, data, headers)
+		_, statusCode := c.vminsertCli.Post(t, url, data, headers)
 		if statusCode != http.StatusNoContent {
 			t.Fatalf("unexpected status code: got %d, want %d", statusCode, http.StatusNoContent)
 		}
@@ -853,7 +853,7 @@ func (c *vminsertClient) ZabbixConnectorHistory(t *testing.T, records []string,
 	headers := opts.getHeaders()
 	headers.Set("Content-Type", "application/json")
 	c.sendBlocking(t, len(records), func() {
-		_, statusCode := c.cli.Post(t, url, data, headers)
+		_, statusCode := c.vminsertCli.Post(t, url, data, headers)
 		if statusCode != http.StatusOK {
 			t.Fatalf("unexpected status code: got %d, want %d", statusCode, http.StatusOK)
 		}
@@ -867,11 +867,11 @@ func (c *vminsertClient) ZabbixConnectorHistory(t *testing.T, records []string,
 // See https://docs.victoriametrics.com/victoriametrics/integrations/graphite/#ingesting
 func (c *vminsertClient) GraphiteWrite(t *testing.T, records []string, _ QueryOpts) {
 	t.Helper()
-	c.cli.Write(t, c.graphiteListenAddr, records)
+	c.vminsertCli.Write(t, c.graphiteListenAddr, records)
 }
 
 type vmstorageClient struct {
-	cli            *Client
+	vmstorageCli   *Client
 	httpListenAddr string
 }
 
@@ -881,7 +881,7 @@ func (c *vmstorageClient) ForceFlush(t *testing.T) {
 	t.Helper()
 
 	url := fmt.Sprintf("http://%s/internal/force_flush", c.httpListenAddr)
-	_, statusCode := c.cli.Get(t, url, nil)
+	_, statusCode := c.vmstorageCli.Get(t, url, nil)
 	if statusCode != http.StatusOK {
 		t.Fatalf("unexpected status code: got %d, want %d", statusCode, http.StatusOK)
 	}
@@ -892,7 +892,7 @@ func (c *vmstorageClient) ForceMerge(t *testing.T) {
 	t.Helper()
 
 	url := fmt.Sprintf("http://%s/internal/force_merge", c.httpListenAddr)
-	_, statusCode := c.cli.Get(t, url, nil)
+	_, statusCode := c.vmstorageCli.Get(t, url, nil)
 	if statusCode != http.StatusOK {
 		t.Fatalf("unexpected status code: got %d, want %d", statusCode, http.StatusOK)
 	}
@@ -905,7 +905,7 @@ func (c *vmstorageClient) ForceMerge(t *testing.T) {
 func (c *vmstorageClient) SnapshotCreate(t *testing.T) *SnapshotCreateResponse {
 	t.Helper()
 
-	data, statusCode := c.cli.Post(t, c.SnapshotCreateURL(), nil, nil)
+	data, statusCode := c.vmstorageCli.Post(t, c.SnapshotCreateURL(), nil, nil)
 	if got, want := statusCode, http.StatusOK; got != want {
 		t.Fatalf("unexpected status code: got %d, want %d, resp text=%q", got, want, data)
 	}
@@ -931,7 +931,7 @@ func (c *vmstorageClient) APIV1AdminTSDBSnapshot(t *testing.T) *APIV1AdminTSDBSn
 	t.Helper()
 
 	url := fmt.Sprintf("http://%s/api/v1/admin/tsdb/snapshot", c.httpListenAddr)
-	data, statusCode := c.cli.Post(t, url, nil, nil)
+	data, statusCode := c.vmstorageCli.Post(t, url, nil, nil)
 	if got, want := statusCode, http.StatusOK; got != want {
 		t.Fatalf("unexpected status code: got %d, want %d, resp text=%q", got, want, data)
 	}
@@ -952,7 +952,7 @@ func (c *vmstorageClient) SnapshotList(t *testing.T) *SnapshotListResponse {
 	t.Helper()
 
 	url := fmt.Sprintf("http://%s/snapshot/list", c.httpListenAddr)
-	data, statusCode := c.cli.Get(t, url, nil)
+	data, statusCode := c.vmstorageCli.Get(t, url, nil)
 	if got, want := statusCode, http.StatusOK; got != want {
 		t.Fatalf("unexpected status code: got %d, want %d, resp text=%q", got, want, data)
 	}
@@ -973,7 +973,7 @@ func (c *vmstorageClient) SnapshotDelete(t *testing.T, snapshotName string) *Sna
 	t.Helper()
 
 	url := fmt.Sprintf("http://%s/snapshot/delete?snapshot=%s", c.httpListenAddr, snapshotName)
-	data, statusCode := c.cli.Delete(t, url)
+	data, statusCode := c.vmstorageCli.Delete(t, url)
 	wantStatusCodes := map[int]bool{
 		http.StatusOK:                  true,
 		http.StatusInternalServerError: true,
@@ -998,7 +998,7 @@ func (c *vmstorageClient) SnapshotDeleteAll(t *testing.T) *SnapshotDeleteAllResp
 	t.Helper()
 
 	url := fmt.Sprintf("http://%s/snapshot/delete_all", c.httpListenAddr)
-	data, statusCode := c.cli.Post(t, url, nil, nil)
+	data, statusCode := c.vmstorageCli.Post(t, url, nil, nil)
 	if got, want := statusCode, http.StatusOK; got != want {
 		t.Fatalf("unexpected status code: got %d, want %d, resp text=%q", got, want, data)
 	}

apptest/vminsert.go

@@ -77,7 +77,7 @@ type vminsertRuntimeValues struct {
 func newVminsert(app *app, cli *Client, rt vminsertRuntimeValues) *Vminsert {
 	metricsClient := newMetricsClient(cli, rt.httpListenAddr)
 	vminsertClient := &vminsertClient{
-		cli: cli,
+		vminsertCli: cli,
 		url: func(op, path string, opts QueryOpts) string {
 			return getClusterPath(rt.httpListenAddr, op, path, opts)
 		},

apptest/vmselect.go

@@ -48,7 +48,7 @@ func newVmselect(app *app, cli *Client, rt vmselectRuntimeValues) *Vmselect {
 		app:           app,
 		metricsClient: newMetricsClient(cli, rt.httpListenAddr),
 		vmselectClient: &vmselectClient{
-			cli: cli,
+			vmselectCli: cli,
 			url: func(op, path string, opts QueryOpts) string {
 				return getClusterPath(rt.httpListenAddr, op, path, opts)
 			},

apptest/vmsingle.go

@@ -58,11 +58,11 @@ func newVmsingle(app *app, cli *Client, rt vmsingleRuntimeValues) *Vmsingle {
 		app:           app,
 		metricsClient: newMetricsClient(cli, rt.httpListenAddr),
 		vmstorageClient: &vmstorageClient{
-			cli:            cli,
+			vmstorageCli:   cli,
 			httpListenAddr: rt.httpListenAddr,
 		},
 		vmselectClient: &vmselectClient{
-			cli: cli,
+			vmselectCli: cli,
 			url: func(op, path string, opts QueryOpts) string {
 				return fmt.Sprintf("http://%s/%s", rt.httpListenAddr, path)
 			},
@@ -70,7 +70,7 @@ func newVmsingle(app *app, cli *Client, rt vmsingleRuntimeValues) *Vmsingle {
 			tenantsURL:               "vmsingle-does-not-serve-tenants",
 		},
 		vminsertClient: &vminsertClient{
-			cli: cli,
+			vminsertCli: cli,
 			url: func(_, path string, _ QueryOpts) string {
 				return fmt.Sprintf("http://%s/%s", rt.httpListenAddr, path)
 			},

apptest/vmstorage.go

@@ -63,7 +63,7 @@ func newVmstorage(app *app, cli *Client, rt vmstorageRuntimeValues) *Vmstorage {
 		app:           app,
 		metricsClient: newMetricsClient(cli, rt.httpListenAddr),
 		vmstorageClient: &vmstorageClient{
-			cli:            cli,
+			vmstorageCli:   cli,
 			httpListenAddr: rt.httpListenAddr,
 		},
 		storageDataPath: rt.storageDataPath,

docs/victoriametrics/changelog/CHANGELOG.md

@@ -26,8 +26,6 @@ See also [LTS releases](https://docs.victoriametrics.com/victoriametrics/lts-rel
 
 ## tip
 
-* FEATURE: [vmagent](https://docs.victoriametrics.com/victoriametrics/vmagent/): enhance metrics relabel debug by adding remote write relabel configs to the relabel configs input. See [#9918](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/9918).
-
 * BUGFIX: [stream aggregation](https://docs.victoriametrics.com/victoriametrics/stream-aggregation/): fix issue with producing aggregated samples with identical timestamps between flushes. See PR [#10808](https://github.com/VictoriaMetrics/VictoriaMetrics/pull/10808) for details.
 
 ## [v1.145.0](https://github.com/VictoriaMetrics/VictoriaMetrics/releases/tag/v1.145.0)

lib/mergeset/table_search_timing_test.go

@@ -94,7 +94,7 @@ func benchmarkTableSearchKeysExt(b *testing.B, tb *Table, keys [][]byte, stripSu
 				}
 				ts.Seek(searchKey)
 				if !ts.NextItem() {
-					panic(fmt.Errorf("BUG: NextItem must return true for searchKeys[%d]=%q; err=%v", i, searchKey, ts.Error()))
+					panic(fmt.Errorf("BUG: NextItem must return true for searchKeys[%d]=%q; err=%w", i, searchKey, ts.Error()))
 				}
 				if !bytes.HasPrefix(ts.Item, searchKey) {
 					panic(fmt.Errorf("BUG: unexpected item found for searchKey[%d]=%q; got %q; want %q", i, searchKey, ts.Item, key))

lib/promrelabel/debug.go

@@ -9,47 +9,47 @@ import (
 )
 
 // WriteMetricRelabelDebug writes /metric-relabel-debug page to w with the corresponding args.
-func WriteMetricRelabelDebug(w io.Writer, targetID, metric, relabelConfigs, rwRelabelConfigs string, rwURLRelabelConfigLength int, format string, err error) {
-	writeRelabelDebug(w, false, targetID, metric, relabelConfigs, rwRelabelConfigs, rwURLRelabelConfigLength, format, err)
+func WriteMetricRelabelDebug(w io.Writer, targetID, metric, relabelConfigs, format string, err error) {
+	writeRelabelDebug(w, false, targetID, metric, relabelConfigs, format, err)
 }
 
 // WriteTargetRelabelDebug writes /target-relabel-debug page to w with the corresponding args.
 func WriteTargetRelabelDebug(w io.Writer, targetID, metric, relabelConfigs, format string, err error) {
-	writeRelabelDebug(w, true, targetID, metric, relabelConfigs, "", 0, format, err)
+	writeRelabelDebug(w, true, targetID, metric, relabelConfigs, format, err)
 }
 
-func writeRelabelDebug(w io.Writer, isTargetRelabel bool, targetID, metric, relabelConfigs, rwRelabelConfigs string, rwURLRelabelConfigLength int, format string, err error) {
+func writeRelabelDebug(w io.Writer, isTargetRelabel bool, targetID, metric, relabelConfigs, format string, err error) {
 	if metric == "" {
 		metric = "{}"
 	}
 	targetURL := ""
 	if err != nil {
-		WriteRelabelDebugSteps(w, targetURL, targetID, format, nil, metric, relabelConfigs, rwRelabelConfigs, rwURLRelabelConfigLength, err)
+		WriteRelabelDebugSteps(w, targetURL, targetID, format, nil, metric, relabelConfigs, err)
 		return
 	}
 
 	metric, err = normalizeInputLabels(metric)
 	if err != nil {
 		err = fmt.Errorf("cannot parse metric: %w", err)
-		WriteRelabelDebugSteps(w, targetURL, targetID, format, nil, metric, relabelConfigs, rwRelabelConfigs, rwURLRelabelConfigLength, err)
+		WriteRelabelDebugSteps(w, targetURL, targetID, format, nil, metric, relabelConfigs, err)
 		return
 	}
 
 	labels, err := promutil.NewLabelsFromString(metric)
 	if err != nil {
 		err = fmt.Errorf("cannot parse metric: %w", err)
-		WriteRelabelDebugSteps(w, targetURL, targetID, format, nil, metric, relabelConfigs, rwRelabelConfigs, rwURLRelabelConfigLength, err)
+		WriteRelabelDebugSteps(w, targetURL, targetID, format, nil, metric, relabelConfigs, err)
 		return
 	}
 	pcs, err := ParseRelabelConfigsData([]byte(relabelConfigs))
 	if err != nil {
 		err = fmt.Errorf("cannot parse relabel configs: %w", err)
-		WriteRelabelDebugSteps(w, targetURL, targetID, format, nil, metric, relabelConfigs, rwRelabelConfigs, rwURLRelabelConfigLength, err)
+		WriteRelabelDebugSteps(w, targetURL, targetID, format, nil, metric, relabelConfigs, err)
 		return
 	}
 
 	dss, targetURL := newDebugRelabelSteps(pcs, labels, isTargetRelabel)
-	WriteRelabelDebugSteps(w, targetURL, targetID, format, dss, metric, relabelConfigs, rwRelabelConfigs, rwURLRelabelConfigLength, nil)
+	WriteRelabelDebugSteps(w, targetURL, targetID, format, dss, metric, relabelConfigs, nil)
 }
 
 func newDebugRelabelSteps(pcs *ParsedConfigs, labels *promutil.Labels, isTargetRelabel bool) ([]DebugStep, string) {

lib/promrelabel/debug.qtpl

@@ -6,15 +6,15 @@
 
 {% stripspace %}
 
-{% func RelabelDebugSteps(targetURL, targetID, format string, dss []DebugStep, metric, relabelConfigs, rwRelabelConfigs string, rwURLRelabelConfigLength int, err error) %}
+{% func RelabelDebugSteps(targetURL, targetID, format string, dss []DebugStep, metric, relabelConfigs  string, err error) %}
   {% if format == "json" %}
-      {%= RelabelDebugStepsJSON(targetURL, targetID, dss, metric, relabelConfigs, rwRelabelConfigs, rwURLRelabelConfigLength, err) %}
+      {%= RelabelDebugStepsJSON(targetURL, targetID, dss, metric, relabelConfigs, err) %}
   {% else %}
-      {%= RelabelDebugStepsHTML(targetURL, targetID, dss, metric, relabelConfigs, rwRelabelConfigs, rwURLRelabelConfigLength, err) %}
+      {%= RelabelDebugStepsHTML(targetURL, targetID, dss, metric, relabelConfigs, err) %}
   {% endif %}
 {% endfunc %}
 
-{% func RelabelDebugStepsHTML(targetURL, targetID string, dss []DebugStep, metric, relabelConfigs, rwRelabelConfigs string, rwURLRelabelConfigLength int, err error) %}
+{% func RelabelDebugStepsHTML(targetURL, targetID string, dss []DebugStep, metric, relabelConfigs string, err error) %}
 <!DOCTYPE html>
 <html lang="en">
 <head>
@@ -49,7 +49,7 @@ function submitRelabelDebugForm(e) {
 
         <div class="m-3">
         <form method="POST" onsubmit="submitRelabelDebugForm(event)">
-            {%= relabelDebugFormInputs(metric, relabelConfigs, rwRelabelConfigs, rwURLRelabelConfigLength) %}
+            {%= relabelDebugFormInputs(metric, relabelConfigs) %}
             {% if targetID != "" %}
               <input type="hidden" name="id" value="{%s targetID %}" />
             {% endif %}
@@ -70,27 +70,12 @@ function submitRelabelDebugForm(e) {
 </html>
 {% endfunc %}
 
-{% func relabelDebugFormInputs(metric, relabelConfigs string, rwRelabelConfigs string, rwURLRelabelConfigLength int) %}
+{% func relabelDebugFormInputs(metric, relabelConfigs string) %}
     <div>
         Relabel configs:<br/>
         <textarea name="relabel_configs" style="width: 100%; height: 15em; font-family: monospace" class="m-1">{%s relabelConfigs %}</textarea>
     </div>
 
-    <div>
-        Remote write relabel configs:<br/>
-        <textarea name="remote_write_relabel_configs" style="width: 100%; height: 15em; font-family: monospace" class="m-1">{%s rwRelabelConfigs %}</textarea>
-    </div>
-
-    <select name="url_relabel_configs_index">
-        <option value="">--select remote write url--</option>
-        {% if rwURLRelabelConfigLength > 0 %}
-            {% for i := range rwURLRelabelConfigLength %}
-            <option value="{%d i %}">remote-write-url-{%d i %}</option>
-            {% endfor %}
-        {% endif %}
-    </select>
-    <input type="submit" name="reload_url_relabel_configs" value="Load" class="btn btn-secondary m-1" />
-
     <div>
         Labels:<br/>
         <textarea name="metric" style="width: 100%; height: 5em; font-family: monospace" class="m-1">{%s metric %}</textarea>
@@ -166,7 +151,7 @@ function submitRelabelDebugForm(e) {
 {% endif %}
 {% endfunc %}
 
-{% func RelabelDebugStepsJSON(targetURL, targetID string, dss []DebugStep, metric, relabelConfigs, rwRelabelConfigs string, rwURLRelabelConfigLength int, err error) %}
+{% func RelabelDebugStepsJSON(targetURL, targetID string, dss []DebugStep, metric, relabelConfigs string, err error) %}
 {
     {% if err != nil %}
         "status": "error",

lib/promrelabel/debug.qtpl.go

@@ -25,37 +25,37 @@ var (
 )
 
 //line lib/promrelabel/debug.qtpl:9
-func StreamRelabelDebugSteps(qw422016 *qt422016.Writer, targetURL, targetID, format string, dss []DebugStep, metric, relabelConfigs, rwRelabelConfigs string, rwURLRelabelConfigLength int, err error) {
+func StreamRelabelDebugSteps(qw422016 *qt422016.Writer, targetURL, targetID, format string, dss []DebugStep, metric, relabelConfigs string, err error) {
 //line lib/promrelabel/debug.qtpl:10
 	if format == "json" {
 //line lib/promrelabel/debug.qtpl:11
-		StreamRelabelDebugStepsJSON(qw422016, targetURL, targetID, dss, metric, relabelConfigs, rwRelabelConfigs, rwURLRelabelConfigLength, err)
+		StreamRelabelDebugStepsJSON(qw422016, targetURL, targetID, dss, metric, relabelConfigs, err)
 //line lib/promrelabel/debug.qtpl:12
 	} else {
 //line lib/promrelabel/debug.qtpl:13
-		StreamRelabelDebugStepsHTML(qw422016, targetURL, targetID, dss, metric, relabelConfigs, rwRelabelConfigs, rwURLRelabelConfigLength, err)
+		StreamRelabelDebugStepsHTML(qw422016, targetURL, targetID, dss, metric, relabelConfigs, err)
 //line lib/promrelabel/debug.qtpl:14
 	}
 //line lib/promrelabel/debug.qtpl:15
 }
 
 //line lib/promrelabel/debug.qtpl:15
-func WriteRelabelDebugSteps(qq422016 qtio422016.Writer, targetURL, targetID, format string, dss []DebugStep, metric, relabelConfigs, rwRelabelConfigs string, rwURLRelabelConfigLength int, err error) {
+func WriteRelabelDebugSteps(qq422016 qtio422016.Writer, targetURL, targetID, format string, dss []DebugStep, metric, relabelConfigs string, err error) {
 //line lib/promrelabel/debug.qtpl:15
 	qw422016 := qt422016.AcquireWriter(qq422016)
 //line lib/promrelabel/debug.qtpl:15
-	StreamRelabelDebugSteps(qw422016, targetURL, targetID, format, dss, metric, relabelConfigs, rwRelabelConfigs, rwURLRelabelConfigLength, err)
+	StreamRelabelDebugSteps(qw422016, targetURL, targetID, format, dss, metric, relabelConfigs, err)
 //line lib/promrelabel/debug.qtpl:15
 	qt422016.ReleaseWriter(qw422016)
 //line lib/promrelabel/debug.qtpl:15
 }
 
 //line lib/promrelabel/debug.qtpl:15
-func RelabelDebugSteps(targetURL, targetID, format string, dss []DebugStep, metric, relabelConfigs, rwRelabelConfigs string, rwURLRelabelConfigLength int, err error) string {
+func RelabelDebugSteps(targetURL, targetID, format string, dss []DebugStep, metric, relabelConfigs string, err error) string {
 //line lib/promrelabel/debug.qtpl:15
 	qb422016 := qt422016.AcquireByteBuffer()
 //line lib/promrelabel/debug.qtpl:15
-	WriteRelabelDebugSteps(qb422016, targetURL, targetID, format, dss, metric, relabelConfigs, rwRelabelConfigs, rwURLRelabelConfigLength, err)
+	WriteRelabelDebugSteps(qb422016, targetURL, targetID, format, dss, metric, relabelConfigs, err)
 //line lib/promrelabel/debug.qtpl:15
 	qs422016 := string(qb422016.B)
 //line lib/promrelabel/debug.qtpl:15
@@ -66,7 +66,7 @@ func RelabelDebugSteps(targetURL, targetID, format string, dss []DebugStep, metr
 }
 
 //line lib/promrelabel/debug.qtpl:17
-func StreamRelabelDebugStepsHTML(qw422016 *qt422016.Writer, targetURL, targetID string, dss []DebugStep, metric, relabelConfigs, rwRelabelConfigs string, rwURLRelabelConfigLength int, err error) {
+func StreamRelabelDebugStepsHTML(qw422016 *qt422016.Writer, targetURL, targetID string, dss []DebugStep, metric, relabelConfigs string, err error) {
 //line lib/promrelabel/debug.qtpl:17
 	qw422016.N().S(`<!DOCTYPE html><html lang="en"><head>`)
 //line lib/promrelabel/debug.qtpl:21
@@ -120,7 +120,7 @@ func StreamRelabelDebugStepsHTML(qw422016 *qt422016.Writer, targetURL, targetID
 //line lib/promrelabel/debug.qtpl:48
 	qw422016.N().S(`<div class="m-3"><form method="POST" onsubmit="submitRelabelDebugForm(event)">`)
 //line lib/promrelabel/debug.qtpl:52
-	streamrelabelDebugFormInputs(qw422016, metric, relabelConfigs, rwRelabelConfigs, rwURLRelabelConfigLength)
+	streamrelabelDebugFormInputs(qw422016, metric, relabelConfigs)
 //line lib/promrelabel/debug.qtpl:53
 	if targetID != "" {
 //line lib/promrelabel/debug.qtpl:53
@@ -153,22 +153,22 @@ func StreamRelabelDebugStepsHTML(qw422016 *qt422016.Writer, targetURL, targetID
 }
 
 //line lib/promrelabel/debug.qtpl:71
-func WriteRelabelDebugStepsHTML(qq422016 qtio422016.Writer, targetURL, targetID string, dss []DebugStep, metric, relabelConfigs, rwRelabelConfigs string, rwURLRelabelConfigLength int, err error) {
+func WriteRelabelDebugStepsHTML(qq422016 qtio422016.Writer, targetURL, targetID string, dss []DebugStep, metric, relabelConfigs string, err error) {
 //line lib/promrelabel/debug.qtpl:71
 	qw422016 := qt422016.AcquireWriter(qq422016)
 //line lib/promrelabel/debug.qtpl:71
-	StreamRelabelDebugStepsHTML(qw422016, targetURL, targetID, dss, metric, relabelConfigs, rwRelabelConfigs, rwURLRelabelConfigLength, err)
+	StreamRelabelDebugStepsHTML(qw422016, targetURL, targetID, dss, metric, relabelConfigs, err)
 //line lib/promrelabel/debug.qtpl:71
 	qt422016.ReleaseWriter(qw422016)
 //line lib/promrelabel/debug.qtpl:71
 }
 
 //line lib/promrelabel/debug.qtpl:71
-func RelabelDebugStepsHTML(targetURL, targetID string, dss []DebugStep, metric, relabelConfigs, rwRelabelConfigs string, rwURLRelabelConfigLength int, err error) string {
+func RelabelDebugStepsHTML(targetURL, targetID string, dss []DebugStep, metric, relabelConfigs string, err error) string {
 //line lib/promrelabel/debug.qtpl:71
 	qb422016 := qt422016.AcquireByteBuffer()
 //line lib/promrelabel/debug.qtpl:71
-	WriteRelabelDebugStepsHTML(qb422016, targetURL, targetID, dss, metric, relabelConfigs, rwRelabelConfigs, rwURLRelabelConfigLength, err)
+	WriteRelabelDebugStepsHTML(qb422016, targetURL, targetID, dss, metric, relabelConfigs, err)
 //line lib/promrelabel/debug.qtpl:71
 	qs422016 := string(qb422016.B)
 //line lib/promrelabel/debug.qtpl:71
@@ -179,350 +179,326 @@ func RelabelDebugStepsHTML(targetURL, targetID string, dss []DebugStep, metric,
 }
 
 //line lib/promrelabel/debug.qtpl:73
-func streamrelabelDebugFormInputs(qw422016 *qt422016.Writer, metric, relabelConfigs string, rwRelabelConfigs string, rwURLRelabelConfigLength int) {
+func streamrelabelDebugFormInputs(qw422016 *qt422016.Writer, metric, relabelConfigs string) {
 //line lib/promrelabel/debug.qtpl:73
 	qw422016.N().S(`<div>Relabel configs:<br/><textarea name="relabel_configs" style="width: 100%; height: 15em; font-family: monospace" class="m-1">`)
 //line lib/promrelabel/debug.qtpl:76
 	qw422016.E().S(relabelConfigs)
 //line lib/promrelabel/debug.qtpl:76
-	qw422016.N().S(`</textarea></div><div>Remote write relabel configs:<br/><textarea name="remote_write_relabel_configs" style="width: 100%; height: 15em; font-family: monospace" class="m-1">`)
+	qw422016.N().S(`</textarea></div><div>Labels:<br/><textarea name="metric" style="width: 100%; height: 5em; font-family: monospace" class="m-1">`)
 //line lib/promrelabel/debug.qtpl:81
-	qw422016.E().S(rwRelabelConfigs)
-//line lib/promrelabel/debug.qtpl:81
-	qw422016.N().S(`</textarea></div><select name="url_relabel_configs_index"><option value="">--select remote write url--</option>`)
-//line lib/promrelabel/debug.qtpl:86
-	if rwURLRelabelConfigLength > 0 {
-//line lib/promrelabel/debug.qtpl:87
-		for i := range rwURLRelabelConfigLength {
-//line lib/promrelabel/debug.qtpl:87
-			qw422016.N().S(`<option value="`)
-//line lib/promrelabel/debug.qtpl:88
-			qw422016.N().D(i)
-//line lib/promrelabel/debug.qtpl:88
-			qw422016.N().S(`">remote-write-url-`)
-//line lib/promrelabel/debug.qtpl:88
-			qw422016.N().D(i)
-//line lib/promrelabel/debug.qtpl:88
-			qw422016.N().S(`</option>`)
-//line lib/promrelabel/debug.qtpl:89
-		}
-//line lib/promrelabel/debug.qtpl:90
-	}
-//line lib/promrelabel/debug.qtpl:90
-	qw422016.N().S(`</select><input type="submit" name="reload_url_relabel_configs" value="Load" class="btn btn-secondary m-1" /><div>Labels:<br/><textarea name="metric" style="width: 100%; height: 5em; font-family: monospace" class="m-1">`)
-//line lib/promrelabel/debug.qtpl:96
 	qw422016.E().S(metric)
-//line lib/promrelabel/debug.qtpl:96
+//line lib/promrelabel/debug.qtpl:81
 	qw422016.N().S(`</textarea></div>`)
-//line lib/promrelabel/debug.qtpl:98
+//line lib/promrelabel/debug.qtpl:83
 }
 
-//line lib/promrelabel/debug.qtpl:98
-func writerelabelDebugFormInputs(qq422016 qtio422016.Writer, metric, relabelConfigs string, rwRelabelConfigs string, rwURLRelabelConfigLength int) {
-//line lib/promrelabel/debug.qtpl:98
+//line lib/promrelabel/debug.qtpl:83
+func writerelabelDebugFormInputs(qq422016 qtio422016.Writer, metric, relabelConfigs string) {
+//line lib/promrelabel/debug.qtpl:83
 	qw422016 := qt422016.AcquireWriter(qq422016)
-//line lib/promrelabel/debug.qtpl:98
-	streamrelabelDebugFormInputs(qw422016, metric, relabelConfigs, rwRelabelConfigs, rwURLRelabelConfigLength)
-//line lib/promrelabel/debug.qtpl:98
+//line lib/promrelabel/debug.qtpl:83
+	streamrelabelDebugFormInputs(qw422016, metric, relabelConfigs)
+//line lib/promrelabel/debug.qtpl:83
 	qt422016.ReleaseWriter(qw422016)
-//line lib/promrelabel/debug.qtpl:98
+//line lib/promrelabel/debug.qtpl:83
 }
 
-//line lib/promrelabel/debug.qtpl:98
-func relabelDebugFormInputs(metric, relabelConfigs string, rwRelabelConfigs string, rwURLRelabelConfigLength int) string {
-//line lib/promrelabel/debug.qtpl:98
+//line lib/promrelabel/debug.qtpl:83
+func relabelDebugFormInputs(metric, relabelConfigs string) string {
+//line lib/promrelabel/debug.qtpl:83
 	qb422016 := qt422016.AcquireByteBuffer()
-//line lib/promrelabel/debug.qtpl:98
-	writerelabelDebugFormInputs(qb422016, metric, relabelConfigs, rwRelabelConfigs, rwURLRelabelConfigLength)
-//line lib/promrelabel/debug.qtpl:98
+//line lib/promrelabel/debug.qtpl:83
+	writerelabelDebugFormInputs(qb422016, metric, relabelConfigs)
+//line lib/promrelabel/debug.qtpl:83
 	qs422016 := string(qb422016.B)
-//line lib/promrelabel/debug.qtpl:98
+//line lib/promrelabel/debug.qtpl:83
 	qt422016.ReleaseByteBuffer(qb422016)
-//line lib/promrelabel/debug.qtpl:98
+//line lib/promrelabel/debug.qtpl:83
 	return qs422016
-//line lib/promrelabel/debug.qtpl:98
+//line lib/promrelabel/debug.qtpl:83
 }
 
-//line lib/promrelabel/debug.qtpl:100
+//line lib/promrelabel/debug.qtpl:85
 func streamrelabelDebugSteps(qw422016 *qt422016.Writer, dss []DebugStep, targetURL, targetID string) {
-//line lib/promrelabel/debug.qtpl:101
+//line lib/promrelabel/debug.qtpl:86
 	if len(dss) > 0 {
-//line lib/promrelabel/debug.qtpl:101
+//line lib/promrelabel/debug.qtpl:86
 		qw422016.N().S(`<div class="m-3"><b>Original labels:</b> <samp>`)
-//line lib/promrelabel/debug.qtpl:103
+//line lib/promrelabel/debug.qtpl:88
 		streammustFormatLabels(qw422016, dss[0].In)
-//line lib/promrelabel/debug.qtpl:103
+//line lib/promrelabel/debug.qtpl:88
 		qw422016.N().S(`</samp></div>`)
-//line lib/promrelabel/debug.qtpl:105
+//line lib/promrelabel/debug.qtpl:90
 	}
-//line lib/promrelabel/debug.qtpl:105
+//line lib/promrelabel/debug.qtpl:90
 	qw422016.N().S(`<table class="table table-striped table-hover table-bordered table-sm"><thead><tr><th scope="col" style="width: 5%">Step</th><th scope="col" style="width: 25%">Relabeling Rule</th><th scope="col" style="width: 35%">Input Labels</th><th scope="col" stile="width: 35%">Output labels</a></tr></thead><tbody>`)
-//line lib/promrelabel/debug.qtpl:116
+//line lib/promrelabel/debug.qtpl:101
 	for i, ds := range dss {
-//line lib/promrelabel/debug.qtpl:118
+//line lib/promrelabel/debug.qtpl:103
 		inLabels, inErr := promutil.NewLabelsFromString(ds.In)
 		outLabels, outErr := promutil.NewLabelsFromString(ds.Out)
 		changedLabels := getChangedLabelNames(inLabels, outLabels)
 
-//line lib/promrelabel/debug.qtpl:121
+//line lib/promrelabel/debug.qtpl:106
 		qw422016.N().S(`<tr><td>`)
-//line lib/promrelabel/debug.qtpl:123
+//line lib/promrelabel/debug.qtpl:108
 		qw422016.N().D(i)
-//line lib/promrelabel/debug.qtpl:123
+//line lib/promrelabel/debug.qtpl:108
 		qw422016.N().S(`</td><td><b><pre class="m-2">`)
-//line lib/promrelabel/debug.qtpl:124
+//line lib/promrelabel/debug.qtpl:109
 		qw422016.E().S(ds.Rule)
-//line lib/promrelabel/debug.qtpl:124
+//line lib/promrelabel/debug.qtpl:109
 		qw422016.N().S(`</pre></b></td><td>`)
-//line lib/promrelabel/debug.qtpl:126
+//line lib/promrelabel/debug.qtpl:111
 		if inErr == nil {
-//line lib/promrelabel/debug.qtpl:126
+//line lib/promrelabel/debug.qtpl:111
 			qw422016.N().S(`<div class="m-2" style="font-size: 0.9em" title="deleted and updated labels highlighted in red">`)
-//line lib/promrelabel/debug.qtpl:128
+//line lib/promrelabel/debug.qtpl:113
 			streamlabelsWithHighlight(qw422016, inLabels, changedLabels, "#D15757")
-//line lib/promrelabel/debug.qtpl:128
+//line lib/promrelabel/debug.qtpl:113
 			qw422016.N().S(`</div>`)
-//line lib/promrelabel/debug.qtpl:130
+//line lib/promrelabel/debug.qtpl:115
 		} else {
-//line lib/promrelabel/debug.qtpl:130
+//line lib/promrelabel/debug.qtpl:115
 			qw422016.N().S(`<div class="m-2" style="font-size: 0.9em; color: red" title="error parsing input labels"><pre>`)
-//line lib/promrelabel/debug.qtpl:132
+//line lib/promrelabel/debug.qtpl:117
 			qw422016.E().S(inErr.Error())
-//line lib/promrelabel/debug.qtpl:132
+//line lib/promrelabel/debug.qtpl:117
 			qw422016.N().S(`</pre></div>`)
-//line lib/promrelabel/debug.qtpl:134
+//line lib/promrelabel/debug.qtpl:119
 			break
-//line lib/promrelabel/debug.qtpl:135
+//line lib/promrelabel/debug.qtpl:120
 		}
-//line lib/promrelabel/debug.qtpl:135
+//line lib/promrelabel/debug.qtpl:120
 		qw422016.N().S(`</td><td>`)
-//line lib/promrelabel/debug.qtpl:138
+//line lib/promrelabel/debug.qtpl:123
 		if outErr == nil {
-//line lib/promrelabel/debug.qtpl:138
+//line lib/promrelabel/debug.qtpl:123
 			qw422016.N().S(`<div class="m-2" style="font-size: 0.9em" title="added and updated labels highlighted in blue">`)
-//line lib/promrelabel/debug.qtpl:140
+//line lib/promrelabel/debug.qtpl:125
 			streamlabelsWithHighlight(qw422016, outLabels, changedLabels, "#4495e0")
-//line lib/promrelabel/debug.qtpl:140
+//line lib/promrelabel/debug.qtpl:125
 			qw422016.N().S(`</div>`)
-//line lib/promrelabel/debug.qtpl:142
+//line lib/promrelabel/debug.qtpl:127
 		} else {
-//line lib/promrelabel/debug.qtpl:142
+//line lib/promrelabel/debug.qtpl:127
 			qw422016.N().S(`<div class="m-2" style="font-size: 0.9em; color: red" title="error parsing output labels"><pre>`)
-//line lib/promrelabel/debug.qtpl:144
+//line lib/promrelabel/debug.qtpl:129
 			qw422016.E().S(outErr.Error())
-//line lib/promrelabel/debug.qtpl:144
+//line lib/promrelabel/debug.qtpl:129
 			qw422016.N().S(`</pre></div>`)
-//line lib/promrelabel/debug.qtpl:146
+//line lib/promrelabel/debug.qtpl:131
 			break
-//line lib/promrelabel/debug.qtpl:147
+//line lib/promrelabel/debug.qtpl:132
 		}
-//line lib/promrelabel/debug.qtpl:147
+//line lib/promrelabel/debug.qtpl:132
 		qw422016.N().S(`</td></tr>`)
-//line lib/promrelabel/debug.qtpl:150
+//line lib/promrelabel/debug.qtpl:135
 	}
-//line lib/promrelabel/debug.qtpl:150
+//line lib/promrelabel/debug.qtpl:135
 	qw422016.N().S(`</tbody></table>`)
-//line lib/promrelabel/debug.qtpl:153
+//line lib/promrelabel/debug.qtpl:138
 	if len(dss) > 0 {
-//line lib/promrelabel/debug.qtpl:153
+//line lib/promrelabel/debug.qtpl:138
 		qw422016.N().S(`<div class="m-3"><b>Resulting labels:</b> <samp>`)
-//line lib/promrelabel/debug.qtpl:155
+//line lib/promrelabel/debug.qtpl:140
 		streammustFormatLabels(qw422016, dss[len(dss)-1].Out)
-//line lib/promrelabel/debug.qtpl:155
+//line lib/promrelabel/debug.qtpl:140
 		qw422016.N().S(`</samp>`)
-//line lib/promrelabel/debug.qtpl:156
+//line lib/promrelabel/debug.qtpl:141
 		if targetURL != "" {
-//line lib/promrelabel/debug.qtpl:156
+//line lib/promrelabel/debug.qtpl:141
 			qw422016.N().S(`<div><b>Target URL:</b>`)
-//line lib/promrelabel/debug.qtpl:158
+//line lib/promrelabel/debug.qtpl:143
 			qw422016.N().S(` `)
-//line lib/promrelabel/debug.qtpl:158
+//line lib/promrelabel/debug.qtpl:143
 			qw422016.N().S(`<a href="`)
-//line lib/promrelabel/debug.qtpl:158
+//line lib/promrelabel/debug.qtpl:143
 			qw422016.E().S(targetURL)
-//line lib/promrelabel/debug.qtpl:158
+//line lib/promrelabel/debug.qtpl:143
 			qw422016.N().S(`" target="_blank">`)
-//line lib/promrelabel/debug.qtpl:158
+//line lib/promrelabel/debug.qtpl:143
 			qw422016.E().S(targetURL)
-//line lib/promrelabel/debug.qtpl:158
+//line lib/promrelabel/debug.qtpl:143
 			qw422016.N().S(`</a>`)
-//line lib/promrelabel/debug.qtpl:159
+//line lib/promrelabel/debug.qtpl:144
 			if targetID != "" {
-//line lib/promrelabel/debug.qtpl:160
+//line lib/promrelabel/debug.qtpl:145
 				qw422016.N().S(` `)
-//line lib/promrelabel/debug.qtpl:160
+//line lib/promrelabel/debug.qtpl:145
 				qw422016.N().S(`(<a href="target_response?id=`)
-//line lib/promrelabel/debug.qtpl:161
+//line lib/promrelabel/debug.qtpl:146
 				qw422016.E().S(targetID)
-//line lib/promrelabel/debug.qtpl:161
+//line lib/promrelabel/debug.qtpl:146
 				qw422016.N().S(`" target="_blank" title="click to fetch target response on behalf of the scraper">response</a>)`)
-//line lib/promrelabel/debug.qtpl:162
+//line lib/promrelabel/debug.qtpl:147
 			}
-//line lib/promrelabel/debug.qtpl:162
+//line lib/promrelabel/debug.qtpl:147
 			qw422016.N().S(`</div>`)
-//line lib/promrelabel/debug.qtpl:164
+//line lib/promrelabel/debug.qtpl:149
 		}
-//line lib/promrelabel/debug.qtpl:164
+//line lib/promrelabel/debug.qtpl:149
 		qw422016.N().S(`</div>`)
-//line lib/promrelabel/debug.qtpl:166
+//line lib/promrelabel/debug.qtpl:151
 	}
-//line lib/promrelabel/debug.qtpl:167
+//line lib/promrelabel/debug.qtpl:152
 }
 
-//line lib/promrelabel/debug.qtpl:167
+//line lib/promrelabel/debug.qtpl:152
 func writerelabelDebugSteps(qq422016 qtio422016.Writer, dss []DebugStep, targetURL, targetID string) {
-//line lib/promrelabel/debug.qtpl:167
+//line lib/promrelabel/debug.qtpl:152
 	qw422016 := qt422016.AcquireWriter(qq422016)
-//line lib/promrelabel/debug.qtpl:167
+//line lib/promrelabel/debug.qtpl:152
 	streamrelabelDebugSteps(qw422016, dss, targetURL, targetID)
-//line lib/promrelabel/debug.qtpl:167
+//line lib/promrelabel/debug.qtpl:152
 	qt422016.ReleaseWriter(qw422016)
-//line lib/promrelabel/debug.qtpl:167
+//line lib/promrelabel/debug.qtpl:152
 }
 
-//line lib/promrelabel/debug.qtpl:167
+//line lib/promrelabel/debug.qtpl:152
 func relabelDebugSteps(dss []DebugStep, targetURL, targetID string) string {
-//line lib/promrelabel/debug.qtpl:167
+//line lib/promrelabel/debug.qtpl:152
 	qb422016 := qt422016.AcquireByteBuffer()
-//line lib/promrelabel/debug.qtpl:167
+//line lib/promrelabel/debug.qtpl:152
 	writerelabelDebugSteps(qb422016, dss, targetURL, targetID)
-//line lib/promrelabel/debug.qtpl:167
+//line lib/promrelabel/debug.qtpl:152
 	qs422016 := string(qb422016.B)
-//line lib/promrelabel/debug.qtpl:167
+//line lib/promrelabel/debug.qtpl:152
 	qt422016.ReleaseByteBuffer(qb422016)
-//line lib/promrelabel/debug.qtpl:167
+//line lib/promrelabel/debug.qtpl:152
 	return qs422016
-//line lib/promrelabel/debug.qtpl:167
+//line lib/promrelabel/debug.qtpl:152
 }
 
-//line lib/promrelabel/debug.qtpl:169
-func StreamRelabelDebugStepsJSON(qw422016 *qt422016.Writer, targetURL, targetID string, dss []DebugStep, metric, relabelConfigs, rwRelabelConfigs string, rwURLRelabelConfigLength int, err error) {
-//line lib/promrelabel/debug.qtpl:169
+//line lib/promrelabel/debug.qtpl:154
+func StreamRelabelDebugStepsJSON(qw422016 *qt422016.Writer, targetURL, targetID string, dss []DebugStep, metric, relabelConfigs string, err error) {
+//line lib/promrelabel/debug.qtpl:154
 	qw422016.N().S(`{`)
-//line lib/promrelabel/debug.qtpl:171
+//line lib/promrelabel/debug.qtpl:156
 	if err != nil {
-//line lib/promrelabel/debug.qtpl:171
+//line lib/promrelabel/debug.qtpl:156
 		qw422016.N().S(`"status": "error","error":`)
-//line lib/promrelabel/debug.qtpl:173
+//line lib/promrelabel/debug.qtpl:158
 		qw422016.N().Q(fmt.Sprintf("Error: %s", err))
-//line lib/promrelabel/debug.qtpl:174
+//line lib/promrelabel/debug.qtpl:159
 	} else {
-//line lib/promrelabel/debug.qtpl:175
+//line lib/promrelabel/debug.qtpl:160
 		var hasError bool
 
-//line lib/promrelabel/debug.qtpl:175
+//line lib/promrelabel/debug.qtpl:160
 		qw422016.N().S(`"status": "success","steps": [`)
-//line lib/promrelabel/debug.qtpl:178
+//line lib/promrelabel/debug.qtpl:163
 		for i, ds := range dss {
-//line lib/promrelabel/debug.qtpl:180
+//line lib/promrelabel/debug.qtpl:165
 			inLabels, inErr := promutil.NewLabelsFromString(ds.In)
 			outLabels, outErr := promutil.NewLabelsFromString(ds.Out)
 			changedLabels := getChangedLabelNames(inLabels, outLabels)
 
-//line lib/promrelabel/debug.qtpl:183
+//line lib/promrelabel/debug.qtpl:168
 			qw422016.N().S(`{"inLabels":`)
-//line lib/promrelabel/debug.qtpl:185
+//line lib/promrelabel/debug.qtpl:170
 			qw422016.N().Q(labelsWithHighlight(inLabels, changedLabels, "#D15757"))
-//line lib/promrelabel/debug.qtpl:185
+//line lib/promrelabel/debug.qtpl:170
 			qw422016.N().S(`,"outLabels":`)
-//line lib/promrelabel/debug.qtpl:186
+//line lib/promrelabel/debug.qtpl:171
 			qw422016.N().Q(labelsWithHighlight(outLabels, changedLabels, "#4495e0"))
-//line lib/promrelabel/debug.qtpl:186
+//line lib/promrelabel/debug.qtpl:171
 			qw422016.N().S(`,"rule":`)
-//line lib/promrelabel/debug.qtpl:187
+//line lib/promrelabel/debug.qtpl:172
 			qw422016.N().Q(ds.Rule)
-//line lib/promrelabel/debug.qtpl:187
+//line lib/promrelabel/debug.qtpl:172
 			qw422016.N().S(`,"errors": {`)
-//line lib/promrelabel/debug.qtpl:189
+//line lib/promrelabel/debug.qtpl:174
 			if inErr != nil {
-//line lib/promrelabel/debug.qtpl:189
+//line lib/promrelabel/debug.qtpl:174
 				qw422016.N().S(`"inLabels":`)
-//line lib/promrelabel/debug.qtpl:190
+//line lib/promrelabel/debug.qtpl:175
 				qw422016.N().Q(`<span style="color: #D15757">` + inErr.Error() + `</span>`)
-//line lib/promrelabel/debug.qtpl:190
+//line lib/promrelabel/debug.qtpl:175
 				if outErr != nil {
-//line lib/promrelabel/debug.qtpl:190
+//line lib/promrelabel/debug.qtpl:175
 					qw422016.N().S(`,`)
-//line lib/promrelabel/debug.qtpl:190
+//line lib/promrelabel/debug.qtpl:175
 				}
-//line lib/promrelabel/debug.qtpl:191
+//line lib/promrelabel/debug.qtpl:176
 				hasError = true
 
-//line lib/promrelabel/debug.qtpl:192
+//line lib/promrelabel/debug.qtpl:177
 			} else {
-//line lib/promrelabel/debug.qtpl:193
+//line lib/promrelabel/debug.qtpl:178
 			}
-//line lib/promrelabel/debug.qtpl:194
+//line lib/promrelabel/debug.qtpl:179
 			if outErr != nil {
-//line lib/promrelabel/debug.qtpl:194
+//line lib/promrelabel/debug.qtpl:179
 				qw422016.N().S(`"outLabels":`)
-//line lib/promrelabel/debug.qtpl:195
+//line lib/promrelabel/debug.qtpl:180
 				qw422016.N().Q(`<span style="color: #D15757">` + outErr.Error() + `</span>`)
-//line lib/promrelabel/debug.qtpl:196
+//line lib/promrelabel/debug.qtpl:181
 				hasError = true
 
-//line lib/promrelabel/debug.qtpl:197
+//line lib/promrelabel/debug.qtpl:182
 			}
-//line lib/promrelabel/debug.qtpl:197
+//line lib/promrelabel/debug.qtpl:182
 			qw422016.N().S(`}}`)
-//line lib/promrelabel/debug.qtpl:200
+//line lib/promrelabel/debug.qtpl:185
 			if i != len(dss)-1 {
-//line lib/promrelabel/debug.qtpl:200
+//line lib/promrelabel/debug.qtpl:185
 				qw422016.N().S(`,`)
-//line lib/promrelabel/debug.qtpl:200
+//line lib/promrelabel/debug.qtpl:185
 			}
-//line lib/promrelabel/debug.qtpl:201
+//line lib/promrelabel/debug.qtpl:186
 		}
-//line lib/promrelabel/debug.qtpl:201
+//line lib/promrelabel/debug.qtpl:186
 		qw422016.N().S(`]`)
-//line lib/promrelabel/debug.qtpl:203
+//line lib/promrelabel/debug.qtpl:188
 		if len(dss) > 0 && !hasError {
-//line lib/promrelabel/debug.qtpl:203
+//line lib/promrelabel/debug.qtpl:188
 			qw422016.N().S(`,"originalLabels":`)
-//line lib/promrelabel/debug.qtpl:205
+//line lib/promrelabel/debug.qtpl:190
 			qw422016.N().Q(mustFormatLabels(dss[0].In))
-//line lib/promrelabel/debug.qtpl:205
+//line lib/promrelabel/debug.qtpl:190
 			qw422016.N().S(`,"resultingLabels":`)
-//line lib/promrelabel/debug.qtpl:206
+//line lib/promrelabel/debug.qtpl:191
 			qw422016.N().Q(mustFormatLabels(dss[len(dss)-1].Out))
-//line lib/promrelabel/debug.qtpl:207
+//line lib/promrelabel/debug.qtpl:192
 		}
-//line lib/promrelabel/debug.qtpl:208
+//line lib/promrelabel/debug.qtpl:193
 	}
-//line lib/promrelabel/debug.qtpl:208
+//line lib/promrelabel/debug.qtpl:193
 	qw422016.N().S(`}`)
-//line lib/promrelabel/debug.qtpl:210
+//line lib/promrelabel/debug.qtpl:195
 }
 
-//line lib/promrelabel/debug.qtpl:210
-func WriteRelabelDebugStepsJSON(qq422016 qtio422016.Writer, targetURL, targetID string, dss []DebugStep, metric, relabelConfigs, rwRelabelConfigs string, rwURLRelabelConfigLength int, err error) {
-//line lib/promrelabel/debug.qtpl:210
+//line lib/promrelabel/debug.qtpl:195
+func WriteRelabelDebugStepsJSON(qq422016 qtio422016.Writer, targetURL, targetID string, dss []DebugStep, metric, relabelConfigs string, err error) {
+//line lib/promrelabel/debug.qtpl:195
 	qw422016 := qt422016.AcquireWriter(qq422016)
-//line lib/promrelabel/debug.qtpl:210
-	StreamRelabelDebugStepsJSON(qw422016, targetURL, targetID, dss, metric, relabelConfigs, rwRelabelConfigs, rwURLRelabelConfigLength, err)
-//line lib/promrelabel/debug.qtpl:210
+//line lib/promrelabel/debug.qtpl:195
+	StreamRelabelDebugStepsJSON(qw422016, targetURL, targetID, dss, metric, relabelConfigs, err)
+//line lib/promrelabel/debug.qtpl:195
 	qt422016.ReleaseWriter(qw422016)
-//line lib/promrelabel/debug.qtpl:210
+//line lib/promrelabel/debug.qtpl:195
 }
 
-//line lib/promrelabel/debug.qtpl:210
-func RelabelDebugStepsJSON(targetURL, targetID string, dss []DebugStep, metric, relabelConfigs, rwRelabelConfigs string, rwURLRelabelConfigLength int, err error) string {
-//line lib/promrelabel/debug.qtpl:210
+//line lib/promrelabel/debug.qtpl:195
+func RelabelDebugStepsJSON(targetURL, targetID string, dss []DebugStep, metric, relabelConfigs string, err error) string {
+//line lib/promrelabel/debug.qtpl:195
 	qb422016 := qt422016.AcquireByteBuffer()
-//line lib/promrelabel/debug.qtpl:210
-	WriteRelabelDebugStepsJSON(qb422016, targetURL, targetID, dss, metric, relabelConfigs, rwRelabelConfigs, rwURLRelabelConfigLength, err)
-//line lib/promrelabel/debug.qtpl:210
+//line lib/promrelabel/debug.qtpl:195
+	WriteRelabelDebugStepsJSON(qb422016, targetURL, targetID, dss, metric, relabelConfigs, err)
+//line lib/promrelabel/debug.qtpl:195
 	qs422016 := string(qb422016.B)
-//line lib/promrelabel/debug.qtpl:210
+//line lib/promrelabel/debug.qtpl:195
 	qt422016.ReleaseByteBuffer(qb422016)
-//line lib/promrelabel/debug.qtpl:210
+//line lib/promrelabel/debug.qtpl:195
 	return qs422016
-//line lib/promrelabel/debug.qtpl:210
+//line lib/promrelabel/debug.qtpl:195
 }
 
-//line lib/promrelabel/debug.qtpl:212
+//line lib/promrelabel/debug.qtpl:197
 func streamlabelsWithHighlight(qw422016 *qt422016.Writer, labels *promutil.Labels, highlight map[string]struct{}, color string) {
-//line lib/promrelabel/debug.qtpl:214
+//line lib/promrelabel/debug.qtpl:199
 	labelsList := labels.GetLabels()
 	metricName := ""
 	for i, label := range labelsList {
@@ -533,153 +509,153 @@ func streamlabelsWithHighlight(qw422016 *qt422016.Writer, labels *promutil.Label
 		}
 	}
 
-//line lib/promrelabel/debug.qtpl:224
+//line lib/promrelabel/debug.qtpl:209
 	if metricName != "" {
-//line lib/promrelabel/debug.qtpl:225
+//line lib/promrelabel/debug.qtpl:210
 		if _, ok := highlight["__name__"]; ok {
-//line lib/promrelabel/debug.qtpl:225
+//line lib/promrelabel/debug.qtpl:210
 			qw422016.N().S(`<span style="font-weight:bold;color:`)
-//line lib/promrelabel/debug.qtpl:226
+//line lib/promrelabel/debug.qtpl:211
 			qw422016.E().S(color)
-//line lib/promrelabel/debug.qtpl:226
+//line lib/promrelabel/debug.qtpl:211
 			qw422016.N().S(`">`)
-//line lib/promrelabel/debug.qtpl:226
+//line lib/promrelabel/debug.qtpl:211
 			qw422016.E().S(metricName)
-//line lib/promrelabel/debug.qtpl:226
+//line lib/promrelabel/debug.qtpl:211
 			qw422016.N().S(`</span>`)
-//line lib/promrelabel/debug.qtpl:227
+//line lib/promrelabel/debug.qtpl:212
 		} else {
-//line lib/promrelabel/debug.qtpl:228
+//line lib/promrelabel/debug.qtpl:213
 			qw422016.E().S(metricName)
-//line lib/promrelabel/debug.qtpl:229
+//line lib/promrelabel/debug.qtpl:214
 		}
-//line lib/promrelabel/debug.qtpl:230
+//line lib/promrelabel/debug.qtpl:215
 		if len(labelsList) == 0 {
-//line lib/promrelabel/debug.qtpl:230
+//line lib/promrelabel/debug.qtpl:215
 			return
-//line lib/promrelabel/debug.qtpl:230
+//line lib/promrelabel/debug.qtpl:215
 		}
-//line lib/promrelabel/debug.qtpl:231
+//line lib/promrelabel/debug.qtpl:216
 	}
-//line lib/promrelabel/debug.qtpl:231
+//line lib/promrelabel/debug.qtpl:216
 	qw422016.N().S(`{`)
-//line lib/promrelabel/debug.qtpl:233
+//line lib/promrelabel/debug.qtpl:218
 	for i, label := range labelsList {
-//line lib/promrelabel/debug.qtpl:234
+//line lib/promrelabel/debug.qtpl:219
 		if _, ok := highlight[label.Name]; ok {
-//line lib/promrelabel/debug.qtpl:234
+//line lib/promrelabel/debug.qtpl:219
 			qw422016.N().S(`<span style="font-weight:bold;color:`)
-//line lib/promrelabel/debug.qtpl:235
+//line lib/promrelabel/debug.qtpl:220
 			qw422016.E().S(color)
-//line lib/promrelabel/debug.qtpl:235
+//line lib/promrelabel/debug.qtpl:220
 			qw422016.N().S(`">`)
-//line lib/promrelabel/debug.qtpl:235
+//line lib/promrelabel/debug.qtpl:220
 			qw422016.E().S(label.Name)
-//line lib/promrelabel/debug.qtpl:235
+//line lib/promrelabel/debug.qtpl:220
 			qw422016.N().S(`=`)
-//line lib/promrelabel/debug.qtpl:235
+//line lib/promrelabel/debug.qtpl:220
 			qw422016.E().Q(label.Value)
-//line lib/promrelabel/debug.qtpl:235
+//line lib/promrelabel/debug.qtpl:220
 			qw422016.N().S(`</span>`)
-//line lib/promrelabel/debug.qtpl:236
+//line lib/promrelabel/debug.qtpl:221
 		} else {
-//line lib/promrelabel/debug.qtpl:237
+//line lib/promrelabel/debug.qtpl:222
 			qw422016.E().S(label.Name)
-//line lib/promrelabel/debug.qtpl:237
+//line lib/promrelabel/debug.qtpl:222
 			qw422016.N().S(`=`)
-//line lib/promrelabel/debug.qtpl:237
+//line lib/promrelabel/debug.qtpl:222
 			qw422016.E().Q(label.Value)
-//line lib/promrelabel/debug.qtpl:238
+//line lib/promrelabel/debug.qtpl:223
 		}
-//line lib/promrelabel/debug.qtpl:239
+//line lib/promrelabel/debug.qtpl:224
 		if i < len(labelsList)-1 {
-//line lib/promrelabel/debug.qtpl:239
+//line lib/promrelabel/debug.qtpl:224
 			qw422016.N().S(`,`)
-//line lib/promrelabel/debug.qtpl:239
+//line lib/promrelabel/debug.qtpl:224
 			qw422016.N().S(` `)
-//line lib/promrelabel/debug.qtpl:239
+//line lib/promrelabel/debug.qtpl:224
 		}
-//line lib/promrelabel/debug.qtpl:240
+//line lib/promrelabel/debug.qtpl:225
 	}
-//line lib/promrelabel/debug.qtpl:240
+//line lib/promrelabel/debug.qtpl:225
 	qw422016.N().S(`}`)
-//line lib/promrelabel/debug.qtpl:242
+//line lib/promrelabel/debug.qtpl:227
 }
 
-//line lib/promrelabel/debug.qtpl:242
+//line lib/promrelabel/debug.qtpl:227
 func writelabelsWithHighlight(qq422016 qtio422016.Writer, labels *promutil.Labels, highlight map[string]struct{}, color string) {
-//line lib/promrelabel/debug.qtpl:242
+//line lib/promrelabel/debug.qtpl:227
 	qw422016 := qt422016.AcquireWriter(qq422016)
-//line lib/promrelabel/debug.qtpl:242
+//line lib/promrelabel/debug.qtpl:227
 	streamlabelsWithHighlight(qw422016, labels, highlight, color)
-//line lib/promrelabel/debug.qtpl:242
+//line lib/promrelabel/debug.qtpl:227
 	qt422016.ReleaseWriter(qw422016)
-//line lib/promrelabel/debug.qtpl:242
+//line lib/promrelabel/debug.qtpl:227
 }
 
-//line lib/promrelabel/debug.qtpl:242
+//line lib/promrelabel/debug.qtpl:227
 func labelsWithHighlight(labels *promutil.Labels, highlight map[string]struct{}, color string) string {
-//line lib/promrelabel/debug.qtpl:242
+//line lib/promrelabel/debug.qtpl:227
 	qb422016 := qt422016.AcquireByteBuffer()
-//line lib/promrelabel/debug.qtpl:242
+//line lib/promrelabel/debug.qtpl:227
 	writelabelsWithHighlight(qb422016, labels, highlight, color)
-//line lib/promrelabel/debug.qtpl:242
+//line lib/promrelabel/debug.qtpl:227
 	qs422016 := string(qb422016.B)
-//line lib/promrelabel/debug.qtpl:242
+//line lib/promrelabel/debug.qtpl:227
 	qt422016.ReleaseByteBuffer(qb422016)
-//line lib/promrelabel/debug.qtpl:242
+//line lib/promrelabel/debug.qtpl:227
 	return qs422016
-//line lib/promrelabel/debug.qtpl:242
+//line lib/promrelabel/debug.qtpl:227
 }
 
-//line lib/promrelabel/debug.qtpl:244
+//line lib/promrelabel/debug.qtpl:229
 func streammustFormatLabels(qw422016 *qt422016.Writer, s string) {
-//line lib/promrelabel/debug.qtpl:245
+//line lib/promrelabel/debug.qtpl:230
 	labels, err := promutil.NewLabelsFromString(s)
 
-//line lib/promrelabel/debug.qtpl:246
+//line lib/promrelabel/debug.qtpl:231
 	if err != nil {
-//line lib/promrelabel/debug.qtpl:246
+//line lib/promrelabel/debug.qtpl:231
 		qw422016.N().S(`<span style="color: red" title="error parsing labels:`)
-//line lib/promrelabel/debug.qtpl:247
+//line lib/promrelabel/debug.qtpl:232
 		qw422016.E().S(err.Error())
-//line lib/promrelabel/debug.qtpl:247
+//line lib/promrelabel/debug.qtpl:232
 		qw422016.N().S(`">`)
-//line lib/promrelabel/debug.qtpl:247
+//line lib/promrelabel/debug.qtpl:232
 		qw422016.E().S("error parsing labels: " + err.Error())
-//line lib/promrelabel/debug.qtpl:247
+//line lib/promrelabel/debug.qtpl:232
 		qw422016.N().S(`</span>`)
-//line lib/promrelabel/debug.qtpl:248
+//line lib/promrelabel/debug.qtpl:233
 	} else {
-//line lib/promrelabel/debug.qtpl:249
+//line lib/promrelabel/debug.qtpl:234
 		streamlabelsWithHighlight(qw422016, labels, nil, "")
-//line lib/promrelabel/debug.qtpl:250
+//line lib/promrelabel/debug.qtpl:235
 	}
-//line lib/promrelabel/debug.qtpl:251
+//line lib/promrelabel/debug.qtpl:236
 }
 
-//line lib/promrelabel/debug.qtpl:251
+//line lib/promrelabel/debug.qtpl:236
 func writemustFormatLabels(qq422016 qtio422016.Writer, s string) {
-//line lib/promrelabel/debug.qtpl:251
+//line lib/promrelabel/debug.qtpl:236
 	qw422016 := qt422016.AcquireWriter(qq422016)
-//line lib/promrelabel/debug.qtpl:251
+//line lib/promrelabel/debug.qtpl:236
 	streammustFormatLabels(qw422016, s)
-//line lib/promrelabel/debug.qtpl:251
+//line lib/promrelabel/debug.qtpl:236
 	qt422016.ReleaseWriter(qw422016)
-//line lib/promrelabel/debug.qtpl:251
+//line lib/promrelabel/debug.qtpl:236
 }
 
-//line lib/promrelabel/debug.qtpl:251
+//line lib/promrelabel/debug.qtpl:236
 func mustFormatLabels(s string) string {
-//line lib/promrelabel/debug.qtpl:251
+//line lib/promrelabel/debug.qtpl:236
 	qb422016 := qt422016.AcquireByteBuffer()
-//line lib/promrelabel/debug.qtpl:251
+//line lib/promrelabel/debug.qtpl:236
 	writemustFormatLabels(qb422016, s)
-//line lib/promrelabel/debug.qtpl:251
+//line lib/promrelabel/debug.qtpl:236
 	qs422016 := string(qb422016.B)
-//line lib/promrelabel/debug.qtpl:251
+//line lib/promrelabel/debug.qtpl:236
 	qt422016.ReleaseByteBuffer(qb422016)
-//line lib/promrelabel/debug.qtpl:251
+//line lib/promrelabel/debug.qtpl:236
 	return qs422016
-//line lib/promrelabel/debug.qtpl:251
+//line lib/promrelabel/debug.qtpl:236
 }

lib/promrelabel/debug_test.go

@@ -13,7 +13,7 @@ func TestWriteRelabelDebugSupportFormats(t *testing.T) {
 	f := func(input, rule, expect string) {
 		// execute
 		outputWriter := bytes.NewBuffer(nil)
-		writeRelabelDebug(outputWriter, false, "", input, rule, "", 0, "json", nil)
+		writeRelabelDebug(outputWriter, false, "", input, rule, "json", nil)
 
 		// the response is in JSON with HTML content, extract the `resultingLabels` in JSON and unescape it.
 		resultingLabels := fastjson.GetString(outputWriter.Bytes(), `resultingLabels`)

lib/promscrape/relabel_debug.go

@@ -3,80 +3,34 @@ package promscrape
 import (
 	"fmt"
 	"net/http"
-	"strconv"
 
 	"github.com/VictoriaMetrics/VictoriaMetrics/lib/httpserver"
 	"github.com/VictoriaMetrics/VictoriaMetrics/lib/promrelabel"
 )
 
-// WriteMetricRelabelDebug serves requests to /metric-relabel-debug page.
-// remotewrite-related relabel configs could be empty as vmsingle doesn't provide remote write feature.
-func WriteMetricRelabelDebug(w http.ResponseWriter, r *http.Request, rwGlobalRelabelConfigs string, rwURLRelabelConfigss []string) {
+// WriteMetricRelabelDebug serves requests to /metric-relabel-debug page
+func WriteMetricRelabelDebug(w http.ResponseWriter, r *http.Request) {
 	targetID := r.FormValue("id")
 	metric := r.FormValue("metric")
 	relabelConfigs := r.FormValue("relabel_configs")
-	rwRelabelConfigs := r.FormValue("remote_write_relabel_configs") // global + per-URL configs.
-
-	rwURLRelabelConfigsIdx := r.FormValue("url_relabel_configs_index")     // only for per-URL configs and has to be set with reload_url_relabel_configs.
-	reloadRWURLRelabelConfigs := r.FormValue("reload_url_relabel_configs") // if set, it will reset the whole remote_write_relabel_configs.
-
 	format := r.FormValue("format")
 	var err error
 
-	rwURLRelabelConfigsLength := len(rwURLRelabelConfigss)
-
-	// if everything is not set, we should load the initial data for user.
-	if metric == "" && relabelConfigs == "" && rwRelabelConfigs == "" && rwURLRelabelConfigsIdx == "" && reloadRWURLRelabelConfigs == "" && targetID != "" {
+	if metric == "" && relabelConfigs == "" && targetID != "" {
 		pcs, labels, ok := getMetricRelabelContextByTargetID(targetID)
 		if !ok {
 			err = fmt.Errorf("cannot find target for id=%s", targetID)
 			targetID = ""
 		} else {
 			metric = labels.String()
-			relabelConfigs += pcs.String()
-
-			// by default use the first per-URL remote write relabel config, if exists.
-			rwURLRelabelConfigs := ""
-			if len(rwURLRelabelConfigss) > 0 {
-				rwURLRelabelConfigs = rwURLRelabelConfigss[0]
-			}
-
-			rwRelabelConfigs += "\n# -remoteWrite.relabelConfig"
-			rwRelabelConfigs += "\n" + rwGlobalRelabelConfigs
-			if rwURLRelabelConfigs != "" {
-				rwRelabelConfigs += "\n# -remoteWrite.urlRelabelConfig"
-				rwRelabelConfigs += "\n" + rwURLRelabelConfigs
-			}
+			relabelConfigs = pcs.String()
 		}
 	}
-
-	// if reloadRWURLRelabelConfigs is set, it means user clicked the button and want to reload the rwRelabelConfigs by rwURLRelabelConfigsIdx
-	if reloadRWURLRelabelConfigs != "" {
-		// set the per-URL remote write relabel according to index, any error will fall back the index to 0.
-		rwURLRelabelConfigs := ""
-		if len(rwURLRelabelConfigss) > 0 {
-			// ignore the error if the input is invalid or exceed the length, and fallback to 0.
-			idx, _ := strconv.Atoi(rwURLRelabelConfigsIdx)
-			if idx >= len(rwURLRelabelConfigss) {
-				idx = 0
-			}
-			rwURLRelabelConfigs = rwURLRelabelConfigss[idx]
-		}
-
-		// reload will remove the existing content
-		rwRelabelConfigs = "\n# -remoteWrite.relabelConfig"
-		rwRelabelConfigs += "\n" + rwGlobalRelabelConfigs
-		if rwURLRelabelConfigs != "" {
-			rwRelabelConfigs += "\n# -remoteWrite.urlRelabelConfig"
-			rwRelabelConfigs += "\n" + rwURLRelabelConfigs
-		}
-	}
-
 	if format == "json" {
 		httpserver.EnableCORS(w, r)
 		w.Header().Set("Content-Type", "application/json")
 	}
-	promrelabel.WriteMetricRelabelDebug(w, targetID, metric, relabelConfigs, rwRelabelConfigs, rwURLRelabelConfigsLength, format, err)
+	promrelabel.WriteMetricRelabelDebug(w, targetID, metric, relabelConfigs, format, err)
 }
 
 // WriteTargetRelabelDebug generates response for /target-relabel-debug page