build(deps): bump github/codeql-action from 4.35.3 to 4.35.5

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.35.3 to 4.35.5.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](e46ed2cbd0...9e0d7b8d25)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 4.35.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

.github/workflows/codeql-analysis-go.yml

@@ -52,14 +52,14 @@ jobs:
           restore-keys: go-artifacts-${{ runner.os }}-codeql-analyze-${{ steps.go.outputs.go-version }}-
 
       - name: Initialize CodeQL
-        uses: github/codeql-action/init@e46ed2cbd01164d986452f91f178727624ae40d7  # v4.35.3
+        uses: github/codeql-action/init@9e0d7b8d25671d64c341c19c0152d693099fb5ba  # v4.35.5
         with:
           languages: go
 
       - name: Autobuild
-        uses: github/codeql-action/autobuild@e46ed2cbd01164d986452f91f178727624ae40d7  # v4.35.3
+        uses: github/codeql-action/autobuild@9e0d7b8d25671d64c341c19c0152d693099fb5ba  # v4.35.5
 
       - name: Perform CodeQL Analysis
-        uses: github/codeql-action/analyze@e46ed2cbd01164d986452f91f178727624ae40d7  # v4.35.3
+        uses: github/codeql-action/analyze@9e0d7b8d25671d64c341c19c0152d693099fb5ba  # v4.35.5
         with:
           category: 'language:go'

app/vmagent/remotewrite/remotewrite.go

@@ -12,7 +12,6 @@ import (
 	"sync/atomic"
 	"time"
 
-	"github.com/VictoriaMetrics/VictoriaMetrics/lib/mdx"
 	"github.com/cespare/xxhash/v2"
 
 	"github.com/VictoriaMetrics/metrics"
@@ -104,9 +103,6 @@ var (
 		"cannot be pushed into the configured -remoteWrite.url systems in a timely manner. See https://docs.victoriametrics.com/victoriametrics/vmagent/#disabling-on-disk-persistence")
 	disableMetadataPerURL = flagutil.NewArrayBool("remoteWrite.disableMetadata", "Whether to disable sending metadata to the corresponding -remoteWrite.url. "+
 		"By default, metadata sending is controlled by the global -enableMetadata flag")
-
-	enableMdx = flagutil.NewArrayBool("remoteWrite.mdx.enable", "Whether to only retain metrics from VictoriaMetrics services before sending them to the corresponding -remoteWrite.url. "+
-		"Please see https://docs.victoriametrics.com/victoriametrics/vmagent/#monitoring-data-exchange")
 )
 
 var (
@@ -308,10 +304,6 @@ func initRemoteWriteCtxs(urls []string) {
 	}
 	fs.RegisterPathFsMetrics(*tmpDataPath)
 
-	if slices.Contains(*enableMdx, true) && *shardByURL {
-		logger.Fatalf("-remoteWrite.mdx.enable and -remoteWrite.shardByURL cannot be set to true simultaneously.")
-	}
-
 	if *shardByURL {
 		consistentHashNodes := make([]string, 0, len(urls))
 		for i, url := range urls {
@@ -867,7 +859,6 @@ type remoteWriteCtx struct {
 
 	sas          atomic.Pointer[streamaggr.Aggregators]
 	deduplicator *streamaggr.Deduplicator
-	mdxFilter    *mdx.Filter
 
 	streamAggrKeepInput bool
 	streamAggrDropInput bool
@@ -882,7 +873,6 @@ type remoteWriteCtx struct {
 
 	rowsPushedAfterRelabel *metrics.Counter
 	rowsDroppedByRelabel   *metrics.Counter
-	rowsPreservedByMdx     *metrics.Counter
 
 	pushFailures                 *metrics.Counter
 	metadataDroppedOnPushFailure *metrics.Counter
@@ -969,6 +959,7 @@ func newRemoteWriteCtx(argIdx int, remoteWriteURL *url.URL, sanitizedURL string)
 	for i := range pss {
 		pss[i] = newPendingSeries(fq, &c.useVMProto, sf, rd)
 	}
+
 	rwctx := &remoteWriteCtx{
 		idx:            argIdx,
 		fq:             fq,
@@ -985,15 +976,6 @@ func newRemoteWriteCtx(argIdx int, remoteWriteURL *url.URL, sanitizedURL string)
 	}
 	rwctx.initStreamAggrConfig()
 
-	if enableMdx.GetOptionalArg(argIdx) {
-		rwctx.mdxFilter = mdx.NewFilter()
-		rwctx.rowsPreservedByMdx = metrics.GetOrCreateCounter(fmt.Sprintf(`vmagent_remotewrite_mdx_rows_preserved_total{path=%q,url=%q}`, queuePath, sanitizedURL))
-		_ = metrics.NewGauge(fmt.Sprintf(`vmagent_mdx_tracked_vm_instances{path=%q,url=%q}`, queuePath, sanitizedURL), func() float64 {
-			return float64(rwctx.mdxFilter.VmInstancesCount())
-		})
-
-	}
-
 	return rwctx
 }
 
@@ -1007,10 +989,6 @@ func (rwctx *remoteWriteCtx) MustStop() {
 		rwctx.deduplicator.MustStop()
 		rwctx.deduplicator = nil
 	}
-	if rwctx.mdxFilter != nil {
-		rwctx.mdxFilter.MustStop()
-		rwctx.mdxFilter = nil
-	}
 
 	for _, ps := range rwctx.pss {
 		ps.MustStop()
@@ -1026,7 +1004,6 @@ func (rwctx *remoteWriteCtx) MustStop() {
 
 	rwctx.rowsPushedAfterRelabel = nil
 	rwctx.rowsDroppedByRelabel = nil
-	rwctx.rowsPreservedByMdx = nil
 }
 
 // TryPushTimeSeries sends tss series to the configured remote write endpoint
@@ -1035,38 +1012,24 @@ func (rwctx *remoteWriteCtx) MustStop() {
 func (rwctx *remoteWriteCtx) TryPushTimeSeries(tss []prompb.TimeSeries, forceDropSamplesOnFailure bool) bool {
 	var rctx *relabelCtx
 	var v *[]prompb.TimeSeries
-	acquiredTssFromPool := false
 	defer func() {
-		if acquiredTssFromPool {
-			*v = prompb.ResetTimeSeries(tss)
-			tssPool.Put(v)
-		}
-		if rctx != nil {
-			putRelabelCtx(rctx)
+		if rctx == nil {
+			return
 		}
+		*v = prompb.ResetTimeSeries(tss)
+		tssPool.Put(v)
+		putRelabelCtx(rctx)
 	}()
 
-	if rwctx.mdxFilter != nil {
-		acquiredTssFromPool = true
-		v = tssPool.Get().(*[]prompb.TimeSeries)
-		tss = rwctx.mdxFilter.Filter(tss, *v)
-		rowsCountAfterMdx := getRowsCount(tss)
-		rwctx.rowsPreservedByMdx.Add(rowsCountAfterMdx)
-		if len(tss) == 0 {
-			return true
-		}
-	}
-
 	// Apply relabeling
 	rcs := allRelabelConfigs.Load()
 	pcs := rcs.perURL[rwctx.idx]
 	if pcs.Len() > 0 {
+		rctx = getRelabelCtx()
 		// Make a copy of tss before applying relabeling in order to prevent
 		// from affecting time series for other remoteWrite.url configs.
 		// See https://github.com/VictoriaMetrics/VictoriaMetrics/issues/467
 		// and https://github.com/VictoriaMetrics/VictoriaMetrics/issues/599
-		rctx = getRelabelCtx()
-		acquiredTssFromPool = true
 		v = tssPool.Get().(*[]prompb.TimeSeries)
 		tss = append(*v, tss...)
 		rowsCountBeforeRelabel := getRowsCount(tss)
@@ -1086,7 +1049,6 @@ func (rwctx *remoteWriteCtx) TryPushTimeSeries(tss []prompb.TimeSeries, forceDro
 			if rctx == nil {
 				rctx = getRelabelCtx()
 				// Make a copy of tss before dropping aggregated series
-				acquiredTssFromPool = true
 				v = tssPool.Get().(*[]prompb.TimeSeries)
 				tss = append(*v, tss...)
 			}
@@ -1096,7 +1058,6 @@ func (rwctx *remoteWriteCtx) TryPushTimeSeries(tss []prompb.TimeSeries, forceDro
 			if rctx == nil {
 				rctx = getRelabelCtx()
 				// Make a copy of tss before dropping aggregated series
-				acquiredTssFromPool = true
 				v = tssPool.Get().(*[]prompb.TimeSeries)
 				tss = append(*v, tss...)
 			}

docs/victoriametrics/changelog/CHANGELOG.md

@@ -25,7 +25,6 @@ The sandbox cluster installation runs under the constant load generated by
 See also [LTS releases](https://docs.victoriametrics.com/victoriametrics/lts-releases/).
 
 ## tip
-* FEATURE: [vmagent](https://docs.victoriametrics.com/victoriametrics/vmagent/): introduce `-remoteWrite.mdx.enable` and `-mdx.instanceEntryTTL` command-line flags to support mdx service in `vmagent`, it allows `vmagent` to send only metrics from VictoriaMetrics services to the corresponding `-remoteWrite.url`. See [monitoring-data-exchange](https://docs.victoriametrics.com/victoriametrics/vmagent/#monitoring-data-exchange) and [#10600](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/10600) for detail.
 
 * SECURITY: upgrade Go builder from Go1.26.3 to Go1.26.4. See [the list of issues addressed in Go1.26.4](https://github.com/golang/go/issues?q=milestone%3AGo1.26.4%20label%3ACherryPickApproved).
 

docs/victoriametrics/vmagent.md

@@ -268,31 +268,6 @@ for the collected samples. Examples:
   ```sh
   ./vmagent -remoteWrite.url=http://remote-storage/api/v1/write -streamAggr.dropInputLabels=replica -streamAggr.dedupInterval=60s
   ```
-  
-### Monitoring Data eXchange
-
-The MDX (Monitoring Data eXchange) feature aims to send only metrics from the VictoriaMetrics services to the corresponding `-remoteWrite.url`, discarding metrics from non-VictoriaMetrics services.
-
-To enable MDX, set `-remoteWrite.mdx.enable=true` for the target URL and `-remoteWrite.mdx.enable=false` for other URLs:
-
-```sh
-./vmagent \
-  -remoteWrite.url=http://service-to-keep-all-metrics:8428/api/v1/write \
-  -remoteWrite.mdx.enable=false \
-  -remoteWrite.url=http://service-to-keep-only-vm-metrics:8428/api/v1/write \
-  -remoteWrite.mdx.enable=true 
-```
-When enabling MDX for the `-remoteWrite.url`, `vmagent` will only forward the metrics from the instances that emit `vm_app_version`, which is a metric that all VictoriaMetrics services will emit,
-or the metrics contain the label specified by `mdx.label`:
-
-```sh
-./vmagent \
-  -remoteWrite.url=http://service-to-keep-only-vm-metrics:8428/api/v1/write \
-  -remoteWrite.mdx.enable=true \
-  -mdx.label="service=victoriametrics"
-```
-
-The number of preserved rows from non-VictoriaMetrics services is exposed as `vmagent_remotewrite_mdx_rows_preserved_total`.
 
 ### Life of a sample
 
@@ -310,20 +285,18 @@ flowchart TB
     F --> G[<a href="https://docs.victoriametrics.com/victoriametrics/vmagent/#replication-and-high-availability">replicate</a> to each <b>-remoteWrite.url</b><br/>or <a href="https://docs.victoriametrics.com/victoriametrics/vmagent/#sharding-among-remote-storages">shard</a> if <b>-remoteWrite.shardByURL</b> is set]
 
       %% Left branch
-      G --> H1[per-url <a href="https://docs.victoriametrics.com/victoriametrics/vmagent/#monitoring-data-exchange/">mdx filter</a><br><b>-remoteWrite.mdx.enable</b>]
-      H1 --> H2[per-url <a href="https://docs.victoriametrics.com/victoriametrics/relabeling/">relabeling</a><br><b>-remoteWrite.urlRelabelConfig</b>]
-      H2 --> H3[per-url <a href="https://docs.victoriametrics.com/victoriametrics/stream-aggregation">aggregation</a><br><b>-remoteWrite.streamAggr.config</b><br><b>-remoteWrite.streamAggr.dedupInterval</b>]
-      H3 --> H4["per-url <a href="https://docs.victoriametrics.com/victoriametrics/vmagent/#calculating-disk-space-for-persistence-queue">queue</a> (default: enabled)<br><b>-remoteWrite.disableOnDiskQueue</b>"]
-      H4 --> H5[<a href="https://docs.victoriametrics.com/victoriametrics/vmagent/#adding-labels-to-metrics">add extra labels</a><br><b>-remoteWrite.label</b>]
-      H5 --> H6[[push to <b>-remoteWrite.url</b>]]
+      G --> H1[per-url <a href="https://docs.victoriametrics.com/victoriametrics/relabeling/">relabeling</a><br><b>-remoteWrite.urlRelabelConfig</b>]
+      H1 --> H2[per-url <a href="https://docs.victoriametrics.com/victoriametrics/stream-aggregation">aggregation</a><br><b>-remoteWrite.streamAggr.config</b><br><b>-remoteWrite.streamAggr.dedupInterval</b>]
+      H2 --> H3["per-url <a href="https://docs.victoriametrics.com/victoriametrics/vmagent/#calculating-disk-space-for-persistence-queue">queue</a> (default: enabled)<br><b>-remoteWrite.disableOnDiskQueue</b>"]
+      H3 --> H4[<a href="https://docs.victoriametrics.com/victoriametrics/vmagent/#adding-labels-to-metrics">add extra labels</a><br><b>-remoteWrite.label</b>]
+      H4 --> H5[[push to <b>-remoteWrite.url</b>]]
 
       %% Right branch
-      G --> R1[per-url <a href="https://docs.victoriametrics.com/victoriametrics/vmagent/#monitoring-data-exchange">mdx filter</a><br><b>-remoteWrite.mdx.enable</b>]
-      R1 --> R2[per-url <a href="https://docs.victoriametrics.com/victoriametrics/relabeling/">relabeling</a><br><b>-remoteWrite.urlRelabelConfig</b>]
-      R2 --> R3[per-url <a href="https://docs.victoriametrics.com/victoriametrics/stream-aggregation">aggregation</a><br><b>-remoteWrite.streamAggr.config</b><br><b>-remoteWrite.streamAggr.dedupInterval</b>]
-      R3 --> R4["per-url <a href="https://docs.victoriametrics.com/victoriametrics/vmagent/#calculating-disk-space-for-persistence-queue">queue</a> (default: enabled)<br><b>-remoteWrite.disableOnDiskQueue</b>"]
-      R4 --> R5[<a href="https://docs.victoriametrics.com/victoriametrics/vmagent/#adding-labels-to-metrics">add extra labels</a><br><b>-remoteWrite.label</b>]
-      R5 --> R6[[push to <b>-remoteWrite.url</b>]]
+      G --> R1[per-url <a href="https://docs.victoriametrics.com/victoriametrics/relabeling/">relabeling</a><br><b>-remoteWrite.urlRelabelConfig</b>]
+      R1 --> R2[per-url <a href="https://docs.victoriametrics.com/victoriametrics/stream-aggregation">aggregation</a><br><b>-remoteWrite.streamAggr.config</b><br><b>-remoteWrite.streamAggr.dedupInterval</b>]
+      R2 --> R3["per-url <a href="https://docs.victoriametrics.com/victoriametrics/vmagent/#calculating-disk-space-for-persistence-queue">queue</a> (default: enabled)<br><b>-remoteWrite.disableOnDiskQueue</b>"]
+      R3 --> R4[<a href="https://docs.victoriametrics.com/victoriametrics/vmagent/#adding-labels-to-metrics">add extra labels</a><br><b>-remoteWrite.label</b>]
+      R4 --> R5[[push to <b>-remoteWrite.url</b>]]
 ```
 
 Scraping has additional settings that can be applied before samples are pushed to the processing pipeline above:

lib/mdx/filter.go

@@ -1,159 +0,0 @@
-package mdx
-
-import (
-	"flag"
-	"strconv"
-	"strings"
-	"sync"
-	"sync/atomic"
-	"time"
-
-	"github.com/VictoriaMetrics/VictoriaMetrics/lib/bytesutil"
-	"github.com/VictoriaMetrics/VictoriaMetrics/lib/logger"
-	"github.com/VictoriaMetrics/VictoriaMetrics/lib/prompb"
-)
-
-var (
-	vmLabel = flag.String("mdx.label", "", "Optional label in the form 'name=value' to identify metrics from VictoriaMetrics. The metrics contain this label will be kept and sent to the `-remoteWrite.url` that configured with `-remoteWrite.mdx.enable=true`.")
-)
-
-// Filter manages the list of VictoriaMetrics instances discovered from previous data flow, and uses it to filter out metrics that are not from VictoriaMetrics instances.
-type Filter struct {
-	mu                       sync.RWMutex
-	wg                       sync.WaitGroup
-	stopCh                   chan struct{}
-	vmInstance               map[string]*atomic.Int64
-	filterByLabel            bool
-	filterByCustomLabelName  string
-	filterByCustomLabelValue string
-}
-
-func NewFilter() *Filter {
-	filter := &Filter{
-		vmInstance: make(map[string]*atomic.Int64),
-		stopCh:     make(chan struct{}),
-	}
-
-	if len(*vmLabel) != 0 {
-		n := strings.IndexByte(*vmLabel, '=')
-		if n < 0 {
-			logger.Fatalf("missing '=' in `-mdx.label`. It must contain label in the form `name=value`; got %q", *vmLabel)
-		}
-		filter.filterByCustomLabelName = (*vmLabel)[:n]
-		filter.filterByCustomLabelValue = (*vmLabel)[n+1:]
-		filter.filterByLabel = true
-	}
-
-	filter.wg.Go(filter.cleanStale)
-	return filter
-}
-
-func (filter *Filter) VmInstancesCount() int {
-	filter.mu.RLock()
-	defer filter.mu.RUnlock()
-	return len(filter.vmInstance)
-
-}
-
-func (filter *Filter) cleanStale() {
-	entryTTL := time.Hour * 1
-	ttlSec := int64(entryTTL.Seconds())
-	ticker := time.NewTicker(5 * time.Second)
-	defer ticker.Stop()
-
-	for {
-		select {
-		case <-ticker.C:
-			filter.mu.Lock()
-			currTs := time.Now().Unix()
-
-			dst := make(map[string]*atomic.Int64, len(filter.vmInstance))
-			for k, v := range filter.vmInstance {
-				if currTs-v.Load() < ttlSec {
-					dst[k] = v
-				}
-			}
-			if len(dst) != len(filter.vmInstance) {
-				filter.vmInstance = dst
-			}
-			filter.mu.Unlock()
-		case <-filter.stopCh:
-			return
-		}
-	}
-}
-
-func (filter *Filter) MustStop() {
-	if filter == nil {
-		return
-	}
-	close(filter.stopCh)
-	filter.wg.Wait()
-}
-
-func (filter *Filter) Filter(tss []prompb.TimeSeries, resTss []prompb.TimeSeries) []prompb.TimeSeries {
-	currTs := time.Now().Unix()
-	var identicalKey []byte
-
-nextTss:
-	for _, ts := range tss {
-		var hasVersionLabel, triedJobInstance bool
-		var job, instance string
-		for _, label := range ts.Labels {
-			if filter.filterByLabel && label.Name == filter.filterByCustomLabelName && label.Value == filter.filterByCustomLabelValue {
-				resTss = append(resTss, ts)
-				continue nextTss
-			}
-
-			if label.Name == "__name__" && label.Value == "vm_app_version" {
-				hasVersionLabel = true
-			}
-			if instance == "" && label.Name == "instance" {
-				if label.Value == "" {
-					continue
-				}
-
-				instance = label.Value
-			}
-			if job == "" && label.Name == "job" {
-				if label.Value == "" {
-					continue
-				}
-
-				job = label.Value
-			}
-			if !triedJobInstance && job != "" && instance != "" {
-				identicalKey = identicalKey[:0]
-				identicalKey = strconv.AppendQuote(identicalKey, job)
-				identicalKey = append(identicalKey, ':')
-				identicalKey = strconv.AppendQuote(identicalKey, instance)
-				filter.mu.RLock()
-				ptr, found := filter.vmInstance[bytesutil.ToUnsafeString(identicalKey)]
-				filter.mu.RUnlock()
-				if found {
-					ptr.Store(currTs)
-					resTss = append(resTss, ts)
-					continue nextTss
-				}
-				triedJobInstance = true
-			}
-
-			if hasVersionLabel && job != "" && instance != "" {
-				identicalKey = identicalKey[:0]
-				identicalKey = strconv.AppendQuote(identicalKey, job)
-				identicalKey = append(identicalKey, ':')
-				identicalKey = strconv.AppendQuote(identicalKey, instance)
-
-				v := &atomic.Int64{}
-				v.Store(currTs)
-
-				filter.mu.Lock()
-				filter.vmInstance[string(identicalKey)] = v
-				filter.mu.Unlock()
-				resTss = append(resTss, ts)
-				continue nextTss
-			}
-		}
-	}
-	return resTss
-}

lib/mdx/filter_test.go

@@ -1,216 +0,0 @@
-package mdx
-
-import (
-	"fmt"
-	"sort"
-	"strings"
-	"testing"
-	"testing/synctest"
-	"time"
-
-	"github.com/VictoriaMetrics/VictoriaMetrics/lib/prompb"
-	"github.com/VictoriaMetrics/VictoriaMetrics/lib/promrelabel"
-)
-
-func timeSeriessToString(tss []prompb.TimeSeries) string {
-	a := make([]string, len(tss))
-	for i, ts := range tss {
-		a[i] = timeSeriesToString(ts)
-	}
-	sort.Strings(a)
-	return strings.Join(a, "")
-}
-
-func timeSeriesToString(ts prompb.TimeSeries) string {
-	labelsString := promrelabel.LabelsToString(ts.Labels)
-
-	return fmt.Sprintf("%s\n", labelsString)
-}
-
-func TestMdxInstanceFilter(t *testing.T) {
-
-	filter := NewFilter()
-
-	f := func(input []prompb.TimeSeries, expectedOutput []prompb.TimeSeries, expectedInstanceMap map[string]int64) {
-		t.Helper()
-		output := filter.Filter(input, []prompb.TimeSeries{})
-		if len(output) != len(expectedOutput) {
-			t.Fatalf("unexpected output length; got %d; want %d", len(output), len(expectedOutput))
-		}
-		if timeSeriessToString(output) != timeSeriessToString(expectedOutput) {
-			t.Fatalf("unexpected output; got %s; want %s", timeSeriessToString(output), timeSeriessToString(expectedOutput))
-		}
-		if len(filter.vmInstance) != len(expectedInstanceMap) {
-			t.Fatalf("unexpected instance map length; got %d; want %d", len(filter.vmInstance), len(expectedInstanceMap))
-		}
-		for k := range expectedInstanceMap {
-			if filter.vmInstance[k] == nil {
-				t.Fatalf("missing instance in filter.vmInstance: %q", k)
-			}
-		}
-	}
-	f([]prompb.TimeSeries{{
-		Labels: []prompb.Label{
-			{Name: "__name__", Value: "vm_app_version"},
-			{Name: "instance", Value: "victoria-metrics1:8428"},
-			{Name: "job", Value: "test"},
-		},
-	},
-		{
-			Labels: []prompb.Label{
-				{Name: "__name__", Value: "go_gc_duration_seconds"},
-				{Name: "instance", Value: "node-exporter1"},
-				{Name: "job", Value: "test"},
-			},
-		},
-		{
-			Labels: []prompb.Label{
-				{Name: "__name__", Value: "http_request_duration_seconds"},
-				{Name: "instance", Value: "service1"},
-				{Name: "job", Value: "test"},
-			},
-		},
-		{
-			Labels: []prompb.Label{
-				{Name: "__name__", Value: "vm_app_version"},
-				{Name: "instance", Value: "vmagent1:8429"},
-				{Name: "job", Value: "test"},
-			},
-		}},
-		[]prompb.TimeSeries{
-			{
-				Labels: []prompb.Label{
-					{Name: "__name__", Value: "vm_app_version"},
-					{Name: "instance", Value: "victoria-metrics1:8428"},
-					{Name: "job", Value: "test"},
-				},
-			},
-			{
-				Labels: []prompb.Label{
-					{Name: "__name__", Value: "vm_app_version"},
-					{Name: "instance", Value: "vmagent1:8429"},
-					{Name: "job", Value: "test"},
-				},
-			},
-		}, map[string]int64{
-			fmt.Sprintf("%q:%q", "test", "victoria-metrics1:8428"): 0,
-			fmt.Sprintf("%q:%q", "test", "vmagent1:8429"):          0,
-		})
-
-}
-
-func TestMdxFilterByLabel(t *testing.T) {
-	*vmLabel = "service=victoriametrics"
-	filter := NewFilter()
-	f := func(input []prompb.TimeSeries, expectedOutput []prompb.TimeSeries) {
-		t.Helper()
-		output := filter.Filter(input, []prompb.TimeSeries{})
-		if len(output) != len(expectedOutput) {
-			t.Fatalf("unexpected output length; got %d; want %d", len(output), len(expectedOutput))
-		}
-		if timeSeriessToString(output) != timeSeriessToString(expectedOutput) {
-			t.Fatalf("unexpected output; got %s; want %s", timeSeriessToString(output), timeSeriessToString(expectedOutput))
-		}
-	}
-	f([]prompb.TimeSeries{{
-		Labels: []prompb.Label{
-			{Name: "__name__", Value: "up"},
-			{Name: "instance", Value: "victoria-metrics1:8428"},
-			{Name: "job", Value: "test"},
-			{Name: "service", Value: "victoriametrics"},
-		},
-	},
-		{
-			Labels: []prompb.Label{
-				{Name: "__name__", Value: "go_gc_duration_seconds"},
-				{Name: "instance", Value: "node-exporter1"},
-				{Name: "job", Value: "test"},
-			},
-		}},
-		[]prompb.TimeSeries{
-			{
-				Labels: []prompb.Label{
-					{Name: "__name__", Value: "up"},
-					{Name: "instance", Value: "victoria-metrics1:8428"},
-					{Name: "job", Value: "test"},
-					{Name: "service", Value: "victoriametrics"},
-				},
-			},
-		})
-	*vmLabel = ""
-}
-
-func TestMdxInstanceCleanup(t *testing.T) {
-	t.Helper()
-
-	synctest.Test(t, func(t *testing.T) {
-		filter := NewFilter()
-
-		//  init instance list
-		filter.Filter([]prompb.TimeSeries{
-			{
-				Labels: []prompb.Label{
-					{Name: "__name__", Value: "vm_app_version"},
-					{Name: "instance", Value: "victoria-metrics1:8428"},
-					{Name: "job", Value: "test"},
-				},
-			},
-			{
-				Labels: []prompb.Label{
-					{Name: "__name__", Value: "go_gc_duration_seconds"},
-					{Name: "instance", Value: "node-exporter1"},
-					{Name: "job", Value: "test"},
-				},
-			},
-			{
-				Labels: []prompb.Label{
-					{Name: "__name__", Value: "http_request_duration_seconds"},
-					{Name: "instance", Value: "service1"},
-					{Name: "job", Value: "test"},
-				},
-			},
-			{
-				Labels: []prompb.Label{
-					{Name: "__name__", Value: "vm_app_version"},
-					{Name: "instance", Value: "vmagent1:8429"},
-					{Name: "job", Value: "test"},
-				},
-			}}, []prompb.TimeSeries{},
-		)
-		f := func(expectedInstanceMap map[string]int64) {
-			t.Helper()
-			if len(filter.vmInstance) != len(expectedInstanceMap) {
-				t.Fatalf("unexpected instance map length; got %d; want %d", len(filter.vmInstance), len(expectedInstanceMap))
-			}
-			for k := range expectedInstanceMap {
-				if filter.vmInstance[k] == nil {
-					t.Fatalf("missing instance in filter.vmInstance: %q", k)
-				}
-			}
-		}
-		f(map[string]int64{
-			fmt.Sprintf("%q:%q", "test", "victoria-metrics1:8428"): 0,
-			fmt.Sprintf("%q:%q", "test", "vmagent1:8429"):          0,
-		})
-
-		// receive samples from victoria-metrics1:8428 after 9 seconds.
-		time.Sleep(59 * time.Minute)
-		filter.Filter([]prompb.TimeSeries{
-			{
-				Labels: []prompb.Label{
-					{Name: "__name__", Value: "vm_app_version"},
-					{Name: "instance", Value: "victoria-metrics1:8428"},
-					{Name: "job", Value: "test"},
-				},
-			}}, []prompb.TimeSeries{},
-		)
-
-		// no samples from vmagent1:8429 in the last 10 seconds, so it should be removed from the mdx instance list.
-		time.Sleep(2 * time.Minute)
-		f(map[string]int64{
-			fmt.Sprintf("%q:%q", "test", "victoria-metrics1:8428"): 0,
-		})
-		filter.MustStop()
-	})
-
-}