rms/claude-desktop-debian
1
0
Fork 0
mirror of https://github.com/aaddrick/claude-desktop-debian.git synced 2026-05-17 00:26:21 +03:00
Code Issues Packages Projects Releases Wiki Activity

test: consolidate log_session_env BATS coverage (#548)

Browse Source 
Collapse the four log_session_env cases into two, and tighten the
assertions in both:

  - Old test 1 (substring match per key) + old test 4 (block braces
    on their own lines) → one test using exact-line equality on the
    `lines` array. Locks block structure and per-key formatting in
    a single pass; substring matching could not catch a regression
    that re-ordered keys, dropped indentation, or merged lines.
  - Old test 2 (unset values are KEY=) + old test 3 (empty-string
    is KEY=) → one test covering both code paths. Exact-line match
    proves the value after `=` is truly empty; the previous
    `*'KEY='*` substring would have matched `KEY=value` and the
    old test-3 regex was fragile (depended on trailing newline
    being literal `$'\n'` vs end-of-string `$`).

Net: 77 → 42 lines, 4 → 2 cases, stronger guarantees. No change to
the helper itself or the call sites — issue #548 acceptance criteria
still hold.
This commit is contained in:
aaddrick
2026-05-03 17:17:26 -04:00
parent 77d9b80a19
commit 5cebb5c213
1 changed files with 29 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

73
tests/launcher-common.bats
View File

@@ -110,57 +110,42 @@ teardown() {
log_session_env
run cat "$log_file"
[[ $output == *'env={'* ]]
[[ $output == *'XDG_SESSION_TYPE=wayland'* ]]
[[ $output == *'WAYLAND_DISPLAY=wayland-0'* ]]
[[ $output == *'DISPLAY=:0'* ]]
[[ $output == *'XDG_CURRENT_DESKTOP=KDE'* ]]
[[ $output == *'GTK_IM_MODULE=ibus'* ]]
[[ $output == *'XMODIFIERS=@im=ibus'* ]]
[[ $output == *'QT_IM_MODULE=ibus'* ]]
[[ $output == *'CLAUDE_USE_WAYLAND=1'* ]]
[[ $output == *'CLAUDE_TITLEBAR_STYLE=hybrid'* ]]
[[ $output == *'CLAUDE_GTK_IM_MODULE=xim'* ]]
# Exact-line match locks block structure (open/close braces on
# their own lines) and per-key formatting in one pass.
[[ "${lines[0]}" == 'env={' ]]
[[ "${lines[1]}" == ' XDG_SESSION_TYPE=wayland' ]]
[[ "${lines[2]}" == ' WAYLAND_DISPLAY=wayland-0' ]]
[[ "${lines[3]}" == ' DISPLAY=:0' ]]
[[ "${lines[4]}" == ' XDG_CURRENT_DESKTOP=KDE' ]]
[[ "${lines[5]}" == ' GTK_IM_MODULE=ibus' ]]
[[ "${lines[6]}" == ' XMODIFIERS=@im=ibus' ]]
[[ "${lines[7]}" == ' QT_IM_MODULE=ibus' ]]
[[ "${lines[8]}" == ' CLAUDE_USE_WAYLAND=1' ]]
[[ "${lines[9]}" == ' CLAUDE_TITLEBAR_STYLE=hybrid' ]]
[[ "${lines[10]}" == ' CLAUDE_GTK_IM_MODULE=xim' ]]
[[ "${lines[11]}" == '}' ]]
}
@test "log_session_env: unset values are emitted as KEY= (not omitted)" {
setup_logging
# All env vars left unset by the test setup
log_session_env
run cat "$log_file"
# Each required key must appear with an empty value, not be missing
[[ $output == *'XDG_SESSION_TYPE='* ]]
[[ $output == *'WAYLAND_DISPLAY='* ]]
[[ $output == *'DISPLAY='* ]]
[[ $output == *'XDG_CURRENT_DESKTOP='* ]]
[[ $output == *'GTK_IM_MODULE='* ]]
[[ $output == *'XMODIFIERS='* ]]
[[ $output == *'QT_IM_MODULE='* ]]
[[ $output == *'CLAUDE_USE_WAYLAND='* ]]
[[ $output == *'CLAUDE_TITLEBAR_STYLE='* ]]
[[ $output == *'CLAUDE_GTK_IM_MODULE='* ]]
}
@test "log_session_env: empty value is emitted as KEY= (same as unset)" {
@test "log_session_env: unset/empty values render as 'KEY=' (no value)" {
setup_logging
# All vars unset by setup() except this one, which exercises the
# empty-string branch (must be indistinguishable from unset).
GTK_IM_MODULE=''
log_session_env
run cat "$log_file"
# `KEY=` line must be present with no value after the equals sign
[[ $output =~ GTK_IM_MODULE=$'\n' || $output =~ GTK_IM_MODULE=$ ]]
}
@test "log_session_env: emits opening and closing braces on their own lines" {
setup_logging
log_session_env
run cat "$log_file"
# Opening brace
[[ "${lines[0]}" == 'env={' ]]
# Closing brace as final line
[[ "${lines[${#lines[@]}-1]}" == '}' ]]
# Exact-line match proves the line ends right after '=' — a
# substring like *'KEY='* would also match 'KEY=value'.
[[ "${lines[1]}" == ' XDG_SESSION_TYPE=' ]]
[[ "${lines[2]}" == ' WAYLAND_DISPLAY=' ]]
[[ "${lines[3]}" == ' DISPLAY=' ]]
[[ "${lines[4]}" == ' XDG_CURRENT_DESKTOP=' ]]
[[ "${lines[5]}" == ' GTK_IM_MODULE=' ]]
[[ "${lines[6]}" == ' XMODIFIERS=' ]]
[[ "${lines[7]}" == ' QT_IM_MODULE=' ]]
[[ "${lines[8]}" == ' CLAUDE_USE_WAYLAND=' ]]
[[ "${lines[9]}" == ' CLAUDE_TITLEBAR_STYLE=' ]]
[[ "${lines[10]}" == ' CLAUDE_GTK_IM_MODULE=' ]]
}
# =============================================================================