mirror of
https://github.com/GNS3/gns3-gui.git
synced 2026-05-17 00:46:01 +03:00
Add warning when user tries to run vncviewer on IPv6 host
This commit is contained in:
@@ -979,6 +979,11 @@ class GraphicsView(QtWidgets.QGraphicsView):
|
||||
# returns True to ignore this node.
|
||||
return True
|
||||
|
||||
# TightVNC has lack support of IPv6 host at this moment
|
||||
if "vncviewer" in node.consoleCommand() and ":" in node.consoleHost():
|
||||
QtWidgets.QMessageBox.warning(
|
||||
self, "TightVNC", "TightVNC (vncviewer) may not start because of lack of IPv6 support.")
|
||||
|
||||
try:
|
||||
node.openConsole(aux=aux)
|
||||
except (OSError, ValueError) as e:
|
||||
|
||||
34
tests/test_graphics_view.py
Normal file
34
tests/test_graphics_view.py
Normal file
@@ -0,0 +1,34 @@
|
||||
#!/usr/bin/env python
|
||||
#
|
||||
# Copyright (C) 2017 GNS3 Technologies Inc.
|
||||
#
|
||||
# This program is free software: you can redistribute it and/or modify
|
||||
# it under the terms of the GNU General Public License as published by
|
||||
# the Free Software Foundation, either version 3 of the License, or
|
||||
# (at your option) any later version.
|
||||
#
|
||||
# This program is distributed in the hope that it will be useful,
|
||||
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
# GNU General Public License for more details.
|
||||
#
|
||||
# You should have received a copy of the GNU General Public License
|
||||
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
||||
|
||||
from unittest.mock import MagicMock, patch
|
||||
from gns3.graphics_view import GraphicsView
|
||||
from gns3.node import Node
|
||||
|
||||
|
||||
def test_console_to_node_vncviewer_and_ipv6():
|
||||
node = MagicMock(
|
||||
initialized=MagicMock(return_value=True),
|
||||
status=MagicMock(return_value=Node.started),
|
||||
consoleCommand=MagicMock(return_value="vncviewer"),
|
||||
consoleHost=MagicMock(return_value="::1")
|
||||
)
|
||||
view = GraphicsView.__new__(GraphicsView)
|
||||
with patch('gns3.qt.QtWidgets.QMessageBox.warning') as warning_mock:
|
||||
view.consoleToNode(node)
|
||||
assert warning_mock.called
|
||||
assert warning_mock.call_args[0][1] == 'TightVNC'
|
||||
Reference in New Issue
Block a user