Release v2.2.28

Merge branch 'master' into 2.2
Merge pull request #3272 from etiennewan/patch-1
2026-06-05 10:12:05 +03:00 · 2021-12-15 13:54:24 +10:30 · 2021-12-15 13:52:41 +10:30 · 2021-12-15 09:28:35 +10:00 · 2021-12-13 23:27:28 +01:00 · 2021-11-23 09:15:54 +10:30
8 changed files with 23 additions and 9 deletions
--- a/11
+++ b/11
@@ -1,5 +1,16 @@
 # Change Log

+## 2.2.28 15/12/2021
+
+* Fixed drawLine called with float arguments
+* Fixed dead VIX API link
+
+## 2.2.27 12/11/2021
+
+* Fix symbols in "Symbol selection" dialog are not placed in alphabetical order. Fixes #3245
+* Fix links duplicates in topology summary. Fixes #3251
+* chore : use --no-cache-dir flag to pip in dockerfiles to save space
+
 ## 2.2.26 08/10/2021

 * Upgrade embedded Python to version 3.7 in Windows package
--- a/2
+++ b/2
@@ -8,7 +8,7 @@ RUN apt-get clean

 ADD dev-requirements.txt /dev-requirements.txt
 ADD requirements.txt /requirements.txt
-RUN pip3 install -r /dev-requirements.txt
+RUN pip3 install --no-cache-dir -r /dev-requirements.txt

 ADD . /src
 WORKDIR /src
--- a/gns3/crash_report.py
+++ b/gns3/crash_report.py
@@ -51,7 +51,7 @@ class CrashReport:
    Report crash to a third party service
    """

-    DSN = "https://803fefdf04db46ee9f4f245a53e58e70:91e2e200ee32481a976937182357ecc8@o19455.ingest.sentry.io/38506"
+    DSN = "https://afea6dfc1b52427daa40387216e31764:2aeb84def9164bfaa2136d2684892252@o19455.ingest.sentry.io/38506"
    _instance = None

    def __init__(self):
--- a/gns3/dialogs/setup_wizard.py
+++ b/gns3/dialogs/setup_wizard.py
@@ -127,7 +127,7 @@ class SetupWizard(QtWidgets.QWizard, Ui_SetupWizard):
        from gns3.modules import VMware
        settings = VMware.instance().settings()
        if not os.path.exists(settings["vmrun_path"]):
-            QtWidgets.QMessageBox.critical(self, "VMware", "VMware vmrun tool could not be found, VMware or the VIX API (required for VMware player) is probably not installed. You can download it from https://www.vmware.com/support/developer/vix-api/. After installation you need to restart GNS3.")
+            QtWidgets.QMessageBox.critical(self, "VMware", "VMware vmrun tool could not be found, VMware or the VIX API (required for VMware player) is probably not installed. You can download it from https://customerconnect.vmware.com/downloads/details?downloadGroup=PLAYER-1400-VIX1170&productId=687. After installation you need to restart GNS3.")
            return
        self._refreshVMListSlot()

--- a/gns3/dialogs/symbol_selection_dialog.py
+++ b/gns3/dialogs/symbol_selection_dialog.py
@@ -108,6 +108,9 @@ class SymbolSelectionDialog(QtWidgets.QDialog, Ui_SymbolSelectionDialog):
                item.setIcon(0, icon)

            Controller.instance().getStatic(symbol.url(), qpartial(render, item))
+
+        for parent in self._parents.values():
+            parent.sortChildren(0, QtCore.Qt.AscendingOrder)
        self.adjustSize()

    def _searchTextChangedSlot(self, text):
--- a/gns3/graphics_view.py
+++ b/gns3/graphics_view.py
@@ -326,6 +326,8 @@ class GraphicsView(QtWidgets.QGraphicsView):
        # connect the signals that let the graphics view knows about events such as
        # a new link creation or deletion.
        if self._topology.addLink(link):
+            source_node.addLink(link)
+            destination_node.addLink(link)
            link.add_link_signal.connect(self.addLinkSlot)
            link.delete_link_signal.connect(self.deleteLinkSlot)

@@ -1661,11 +1663,11 @@ class GraphicsView(QtWidgets.QGraphicsView):

                x = left
                while x < rect.right():
-                    painter.drawLine(x, rect.top(), x, rect.bottom())
+                    painter.drawLine(x, int(rect.top()), x, int(rect.bottom()))
                    x += grid
                y = top
                while y < rect.bottom():
-                    painter.drawLine(rect.left(), y, rect.right(), y)
+                    painter.drawLine(int(rect.left()), y, int(rect.right()), y)
                    y += grid
            painter.restore()

--- a/gns3/link.py
+++ b/gns3/link.py
@@ -91,8 +91,6 @@ class Link(QtCore.QObject):

        self._nodes = []
        self._link_style = {}
-        self._source_node.addLink(self)
-        self._destination_node.addLink(self)

        body = self._prepareParams()
        if self._link_id:
--- a/gns3/version.py
+++ b/gns3/version.py
@@ -23,8 +23,8 @@
 # or negative for a release candidate or beta (after the base version
 # number has been incremented)

-__version__ = "2.2.26"
-__version_info__ = (2, 2, 26, 0)
+__version__ = "2.2.28"
+__version_info__ = (2, 2, 28, 0)

 if "dev" in __version__:
    try:
Author	SHA1	Message	Date
grossmj	ec374f173c	Release v2.2.28	2021-12-15 13:54:24 +10:30
grossmj	b8abdc79dc	Merge branch 'master' into 2.2	2021-12-15 13:52:41 +10:30
Jeremy Grossmann	43744eab7e	Merge pull request #3272 from etiennewan/patch-1 Fixed drawLine called with float arguments	2021-12-15 09:28:35 +10:00
Etienne Wan	e16f700e49	Fixed drawLine called with float arguments	2021-12-13 23:27:28 +01:00
Jeremy Grossmann	925d57b2f8	Merge pull request #3263 from FocusedOne/master Fixed dead VIX API link	2021-11-23 09:15:54 +10:30
FocusedOne	eceaea1317	Fixed dead VIX API link Replaced old dead vmware link with current 1.17 version download.	2021-11-22 16:40:01 -06:00
grossmj	4326785dfc	Development on 2.2.28dev1	2021-11-13 16:31:21 +10:30
grossmj	3920c28bde	Release v2.2.27	2021-11-12 15:33:53 +10:30
grossmj	b34f51e4b0	Merge branch 'master' into 2.2	2021-11-12 14:50:55 +10:30
grossmj	ef45b2e0f1	Fix symbols in "Symbol selection" dialog are not placed in alphabetical order. Fixes #3245	2021-11-08 22:20:22 +10:30
grossmj	545a9f53a8	Fix links duplicates in topology summary. Fixes #3251	2021-11-08 21:55:29 +10:30
grossmj	83d9367860	Development on 2.2.27dev1	2021-10-08 21:49:11 +10:30
grossmj	2131f07e5f	Merge branch '2.2'	2021-10-08 21:46:38 +10:30
Jeremy Grossmann	f26c638350	Merge pull request #3237 from SDN-Projects/optimization/pip-no-cache-dir chore : use --no-cache-dir flag to pip in dockerfiles to save space	2021-09-23 09:59:58 +09:30
Pratik Raj	4ea24e622b	chore : use --no-cache-dir flag to pip in dockerfiles to save space using --no-cache-dir flag in pip install ,make sure downloaded packages by pip don't cached on system . This is a best practice which make sure to fetch from repo instead of using local cached one . Further , in case of Docker Containers , by restricting caching , we can reduce image size. In term of stats , it depends upon the number of python packages multiplied by their respective size . e.g for heavy packages with a lot of dependencies it reduce a lot by don't caching pip packages. Further , more detail information can be found at https://medium.com/sciforce/strategies-of-docker-images-optimization-2ca9cc5719b6 Signed-off-by: Pratik Raj <rajpratik71@gmail.com>	2021-09-22 15:13:38 +05:30