tests/12_crawl_https.test

#!/bin/bash
#

set -euo pipefail

bash check-network.sh ||  ! echo "skipping online unit tests" || exit 77

if test "${HTTPS_SUPPORT:-}" == "no"; then
	echo "no https support compiled, skipping"
	exit 77
fi

bash crawl-test.sh --errors 0 --files 5 httrack https://ut.httrack.com/simple/basic.html
Added a basic https unit test. 2013-06-05 19:00:53 +00:00			`#!/bin/bash`
			`#`

tests: run the *.test scripts under set -euo pipefail The test scripts mostly ran with no error flags, so a failing command in the middle would be ignored and the script would limp on to a misleading result. Turn on strict mode everywhere, guarding the spots that legitimately expect a non-zero exit: - the htssafe overflow probes (-#8) deliberately abort, and the strsafe/ cmdline crawls capture an exit code to assert on, so those are run with `\|\| true` / `\|\| rc=$?` rather than letting set -e kill the script first; - the parser fixture crawl ignores httrack's own exit (it checks the mirrored files), so it keeps `\|\| true`; - 02_update-cache replaced `find ... \| grep -q .` with a `-print -quit` command substitution: under pipefail grep -q can close the pipe early and leave find killed by SIGPIPE, which would spuriously fail an existing file; - 12_crawl_https guards $HTTPS_SUPPORT with `${...:-}` for set -u. 02_manpage-regen and 01_engine-cache stay on `set -eu` (no pipefail): both are run via $(BASH), which can be a plain POSIX /bin/sh where `set -o pipefail` does not exist. shellcheck clean; make check: 15 PASS, 7 SKIP (offline). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com> 2026-06-17 06:17:38 +02:00			`set -euo pipefail`

Added a basic https unit test. 2013-06-05 19:00:53 +00:00			`bash check-network.sh \|\| ! echo "skipping online unit tests" \|\| exit 77`

tests: run the *.test scripts under set -euo pipefail The test scripts mostly ran with no error flags, so a failing command in the middle would be ignored and the script would limp on to a misleading result. Turn on strict mode everywhere, guarding the spots that legitimately expect a non-zero exit: - the htssafe overflow probes (-#8) deliberately abort, and the strsafe/ cmdline crawls capture an exit code to assert on, so those are run with `\|\| true` / `\|\| rc=$?` rather than letting set -e kill the script first; - the parser fixture crawl ignores httrack's own exit (it checks the mirrored files), so it keeps `\|\| true`; - 02_update-cache replaced `find ... \| grep -q .` with a `-print -quit` command substitution: under pipefail grep -q can close the pipe early and leave find killed by SIGPIPE, which would spuriously fail an existing file; - 12_crawl_https guards $HTTPS_SUPPORT with `${...:-}` for set -u. 02_manpage-regen and 01_engine-cache stay on `set -eu` (no pipefail): both are run via $(BASH), which can be a plain POSIX /bin/sh where `set -o pipefail` does not exist. shellcheck clean; make check: 15 PASS, 7 SKIP (offline). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com> 2026-06-17 06:17:38 +02:00			`if test "${HTTPS_SUPPORT:-}" == "no"; then`
Added a basic https unit test. 2013-06-05 19:00:53 +00:00			`echo "no https support compiled, skipping"`
			`exit 77`
			`fi`

			`bash crawl-test.sh --errors 0 --files 5 httrack https://ut.httrack.com/simple/basic.html`