mirror of
https://github.com/xroche/httrack.git
synced 2026-07-08 01:46:21 +03:00
bfc4a016ab
The hidden engine self-tests had accreted into a grab-bag of arbitrary
single-letter/-digit -# arms (-#0, -#A, -#W, ...) buried in the htscoremain.c
option switch, with no mnemonics and stale --help text. Collapse them into one
registry: -#test lists every test with a usage hint and one-line description,
and -#test=NAME [args] runs one.
The handlers and the two helpers they used (basic_selftests,
string_safety_selftests) move to a new htsselftest.c keyed by a
{name, args, desc, fn} table; htscoremain.c keeps only a small dispatch that
runs ahead of the no-URL usage gate, so a bare -#test (or an arg-less test like
copyopt/dns/cookies) no longer needs a dummy URL token to be reached. The
genuine debug knobs (-#L, -#C, -#R, -#h, ...) stay as letters in the switch;
only the unit self-tests, whose sole callers are tests/01_engine-*.test, are
renamed, so this is internal-only with no compatibility surface. Behavior is
preserved: each test prints the same result line and exit code, which the
existing assertions pin. Three now-unused includes (htscache_selftest.h,
htsdns_selftest.h, htsencoding.h) drop out of htscoremain.c.
Tests: the engine tests move to -#test=NAME; 01_engine-hashtable now asserts its
success line (not just exit code) so a misrouted registry row can't pass, and a
new 01_engine-selftest-dispatch covers the bare-list and unknown-name paths.
The --help/man "guru options" list now points at -#test instead of enumerating
a stale subset. The lone vestigial alias --debug-testfilters still resolves to
the removed -#0 (it was already non-functional: param1 supplies one argument,
-#0 required two); it is left untouched because editing that array forces
clang-format to reflow the whole untouched table.
Signed-off-by: Xavier Roche <roche@httrack.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
53 lines
2.1 KiB
Bash
Executable File
53 lines
2.1 KiB
Bash
Executable File
#!/bin/bash
|
|
#
|
|
# Keep this POSIX-portable: the harness runs it via $(BASH), which is a plain
|
|
# POSIX /bin/sh on some platforms (e.g. macOS), so avoid bashisms and GNU-only
|
|
# tool flags despite the #!/bin/bash above.
|
|
|
|
# Cache create/read/update logic (driven by 'httrack -#test=cache <dir>').
|
|
#
|
|
# The in-process self-test stores several hand-crafted edge entries (normal
|
|
# HTML, an empty redirect with a near-limit location, a non-HTML body kept via
|
|
# all-in-cache, a binary body with embedded NUL/high bytes), a few thousand
|
|
# small entries (index/lookup scale), and a few large compressible and
|
|
# incompressible bodies (zlib deflate/inflate). It reads everything back
|
|
# asserting every header field and the body round-trip byte for byte, then
|
|
# updates one entry and confirms the new value is read back. It exits non-zero
|
|
# on the first mismatch.
|
|
|
|
set -eu
|
|
|
|
dir=$(mktemp -d)
|
|
trap 'rm -rf "$dir"' EXIT
|
|
|
|
# The working directory is a required argument; without it the test prints a
|
|
# usage line to stderr and returns non-zero.
|
|
out=$(httrack -#test=cache "$dir")
|
|
|
|
# Match the exact success line, so the test cannot pass for an unrelated reason
|
|
# (e.g. the cache test being gone, which prints the registry to stderr but
|
|
# never prints this line).
|
|
test "$out" = "cache-selftest: OK" || {
|
|
echo "expected 'cache-selftest: OK', got: $out" >&2
|
|
exit 1
|
|
}
|
|
|
|
# The self-test must have actually produced a ZIP cache on disk.
|
|
test -e "$dir/hts-cache/new.zip" || {
|
|
echo "no ZIP cache was written by the self-test" >&2
|
|
exit 1
|
|
}
|
|
|
|
# Sanity-check the cache footprint: the few-thousand-entry pass is expected to
|
|
# weigh ~1-2 MB. Fail if it balloons well past that (e.g. a per-entry overhead
|
|
# regression or runaway growth), so the cache size stays bounded.
|
|
# du -sk (1024-byte units) is portable; GNU's -b (apparent bytes) is rejected
|
|
# by BSD/macOS du. Block-allocated size is an upper bound on apparent size,
|
|
# which is all a ceiling check needs.
|
|
ceiling=$((4 * 1024)) # KiB
|
|
kbytes=$(du -sk "$dir/hts-cache" | cut -f1)
|
|
test "$kbytes" -le "$ceiling" || {
|
|
echo "cache footprint ${kbytes} KiB exceeds ${ceiling} KiB ceiling" >&2
|
|
exit 1
|
|
}
|