mirror of
https://github.com/xroche/httrack.git
synced 2026-07-28 19:43:02 +03:00
83079b788d
Under `set -e` a failing command in an EXIT trap becomes the script's exit status, so a hiccup while tearing down fixtures fails a test whose assertions all passed. That is what turned `57_local-proxy-connect.test` red on the Windows x64 leg of #765: five OK lines, no FAIL, exit 1. Every EXIT trap in the suite now runs teardown with errexit off, and the signal traps keep their own `trap` line, since sharing `set +e` with HUP/INT/QUIT/PIPE/TERM would leave errexit off for the rest of a signalled run and let a torn-down test still report success. A `|| true` on the `rm` would have been smaller, but it throws away the only diagnostic, and the evidence does not say which teardown command failed: a blocked `rm -rf` on the Windows runner exits 1 and prints "Device or resource busy", while the log shows exit 1 and nothing at all. The sharing violation in the issue is the plausible mechanism rather than a confirmed one, so whatever it really is now prints its own error. `99_teardown-status.test` pins the semantics both ways and scans the suite so a new test cannot reintroduce the shape, the leaky combined trap included. The `return 0` that three `cleanup()` bodies ended with never protected anything, since errexit fires at the failing command before it is reached. Closes #773 Signed-off-by: Xavier Roche <roche@httrack.com> Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
22 lines
708 B
Bash
22 lines
708 B
Bash
#!/bin/bash
|
|
# A corrupt proxytrack .ndx must not overflow the fixed cache-read buffers. The
|
|
# sanitizer CI build turns any regression here into a hard stack/heap overflow.
|
|
|
|
set -euo pipefail
|
|
|
|
dir=$(mktemp -d)
|
|
trap 'set +e; rm -rf "$dir"' EXIT
|
|
|
|
# The first length-prefixed field declares far more than firstline[256] holds;
|
|
# cache_brstr must clamp the copy to the destination, not the declared length.
|
|
{
|
|
printf '4000\n'
|
|
head -c 4000 /dev/zero | tr '\0' 'A'
|
|
} >"$dir/foo.ndx"
|
|
: >"$dir/foo.dat" # cache_brstr runs only when the sibling .dat opens
|
|
|
|
proxytrack --convert "$dir/out.arc" "$dir/foo.ndx" >/dev/null 2>&1 || {
|
|
echo "FAIL: proxytrack crashed/errored on a corrupt cache index"
|
|
exit 1
|
|
}
|