ci: add a no-python3 job reproducing the Debian buildd chroot

GitHub runners ship python3, so every make-check job exercised the
python3-present path and the local-server tests never skipped. The Debian
buildds build in a minimal chroot with no python3, where those tests must
SKIP (exit 77) -- and 28_local-pause failed there instead, FTBFS on every
arch for 3.49.10-1, invisible to CI.

Add a job that builds, removes python3, and runs make check, so the skip
path is exercised on every PR. Verified to fail on the pre-fix tree and pass
after.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Xavier Roche <roche@httrack.com>

src/htsbasenet.h

@@ -129,8 +129,6 @@ typedef enum HTTPStatusCode {
   HTTP_UNSUPPORTED_MEDIA_TYPE = 415,
   HTTP_REQUESTED_RANGE_NOT_SATISFIABLE = 416,
   HTTP_EXPECTATION_FAILED = 417,
-  HTTP_TOO_MANY_REQUESTS = 429,
-  HTTP_UNAVAILABLE_FOR_LEGAL_REASONS = 451,
   HTTP_INTERNAL_SERVER_ERROR = 500,
   HTTP_NOT_IMPLEMENTED = 501,
   HTTP_BAD_GATEWAY = 502,

src/htscatchurl.c

@@ -64,7 +64,7 @@ Please visit our Website: http://www.httrack.com
 // catch_url_init(&port,&return_host);
 HTSEXT_API T_SOC catch_url_init_std(int *port_prox, char *adr_prox) {
   T_SOC soc;
-  int try_to_listen_to[] = {8080, 3128, 80, 81, 82, 8081, 3129, 0, -1};
+  int try_to_listen_to[] = { 8080, 3128, 80, 81, 82, 8081, 3129, 31337, 0, -1 };
   int i = 0;
 
   do {

src/htscore.c

@@ -1796,18 +1796,90 @@ int httpmirror(char *url1, httrackp * opt) {
         if (strnotempty(savename()) == 0) {       // pas de chemin de sauvegarde
           if (strcmp(urlfil(), "/robots.txt") == 0) {     // robots.txt
             if (r.adr) {
+              int bptr = 0;
+              char BIGSTK line[1024];
+              char BIGSTK buff[8192];
               char BIGSTK infobuff[8192];
-#ifdef IGNORE_RESTRICTIVE_ROBOTS
-              hts_boolean keep_root = (opt->robots >= HTS_ROBOTS_ALWAYS_STRICT)
-                                          ? HTS_TRUE
-                                          : HTS_FALSE;
-#else
-              hts_boolean keep_root = HTS_TRUE;
-#endif
+              int record = 0;
 
-              robots_parse(&robots, urladr(), r.adr, r.size, infobuff,
-                           sizeof(infobuff), keep_root);
-              if (strnotempty(infobuff)) {
+              line[0] = '\0';
+              buff[0] = '\0';
+              infobuff[0] = '\0';
+              //
+#if DEBUG_ROBOTS
+              printf("robots.txt dump:\n%s\n", r.adr);
+#endif
+              do {
+                char *comm;
+                int llen;
+
+                bptr += binput(r.adr + bptr, line, sizeof(line) - 2);
+                /* strip comment */
+                comm = strchr(line, '#');
+                if (comm != NULL) {
+                  *comm = '\0';
+                }
+                /* strip spaces */
+                llen = (int) strlen(line);
+                while(llen > 0 && is_realspace(line[llen - 1])) {
+                  line[llen - 1] = '\0';
+                  llen--;
+                }
+                if (strfield(line, "user-agent:")) {
+                  char *a;
+
+                  a = line + 11;
+                  while(is_realspace(*a))
+                    a++;        // sauter espace(s)
+                  if (*a == '*') {
+                    if (record != 2)
+                      record = 1;       // c pour nous
+                  } else if (strfield(a, "httrack") || strfield(a, "winhttrack")
+                             || strfield(a, "webhttrack")) {
+                    buff[0] = '\0';     // re-enregistrer
+                    infobuff[0] = '\0';
+                    record = 2; // locked
+#if DEBUG_ROBOTS
+                    printf("explicit disallow for httrack\n");
+#endif
+                  } else
+                    record = 0;
+                } else if (record) {
+                  if (strfield(line, "disallow:")) {
+                    char *a = line + 9;
+
+                    while(is_realspace(*a))
+                      a++;      // sauter espace(s)
+                    if (strnotempty(a)) {
+#ifdef IGNORE_RESTRICTIVE_ROBOTS
+                      if (strcmp(a, "/") != 0 ||
+                          opt->robots >= HTS_ROBOTS_ALWAYS_STRICT)
+#endif
+                      { /* ignoring disallow: / */
+                        if ((strlen(buff) + strlen(a) + 8) < sizeof(buff)) {
+                          strcatbuff(buff, a);
+                          strcatbuff(buff, "\n");
+                          if ((strlen(infobuff) + strlen(a) + 8) <
+                              sizeof(infobuff)) {
+                            if (strnotempty(infobuff))
+                              strcatbuff(infobuff, ", ");
+                            strcatbuff(infobuff, a);
+                          }
+                        }
+                      }
+#ifdef IGNORE_RESTRICTIVE_ROBOTS
+                      else {
+                        hts_log_print(opt, LOG_NOTICE,
+                                      "Note: %s robots.txt rules are too restrictive, ignoring /",
+                                      urladr());
+                      }
+#endif
+                    }
+                  }
+                }
+              } while((bptr < r.size) && (strlen(buff) < (sizeof(buff) - 32)));
+              if (strnotempty(buff)) {
+                checkrobots_set(&robots, urladr(), buff);
                 hts_log_print(opt, LOG_INFO,
                               "Note: robots.txt forbidden links for %s are: %s",
                               urladr(), infobuff);

src/htsglobal.h

@@ -229,10 +229,6 @@ Please visit our Website: http://www.httrack.com
 #define HTS_DEFAULT_FOOTER                                                     \
   "<!-- Mirrored from %s%s by HTTrack Website Copier/" HTTRACK_AFF_VERSION     \
   " " HTTRACK_AFF_AUTHORS ", %s -->"
-/* Honest crawler User-Agent; no fake OS/browser to go stale. */
-#define HTS_DEFAULT_USER_AGENT                                                 \
-  "Mozilla/5.0 (compatible; HTTrack/" HTTRACK_AFF_VERSION                      \
-  "; +https://www.httrack.com/)"
 #define HTTRACK_WEB "http://www.httrack.com"
 #define HTS_UPDATE_WEBSITE                                                     \
   "http://www.httrack.com/"                                                    \

src/htslib.c

@@ -563,39 +563,6 @@ const char *hts_mime[][2] = {
   {"", ""}
 };
 
-/* Modern web formats (post-2010), kept in their own table: appending to the
-   legacy hts_mime[] above makes clang-format reflow its whole initializer.
-   Scanned after hts_mime[], so it never shadows a legacy mapping. */
-static const char *hts_mime_modern[][2] = {
-    {"image/webp", "webp"},
-    {"image/avif", "avif"},
-    {"image/heic", "heic"},
-    {"font/woff", "woff"},
-    {"font/woff2", "woff2"},
-    {"font/ttf", "ttf"},
-    {"font/otf", "otf"},
-    {"application/json", "json"},
-    {"application/ld+json", "jsonld"},
-    {"application/manifest+json", "webmanifest"},
-    {"application/wasm", "wasm"},
-    {"text/javascript", "js"},
-    {"text/javascript", "mjs"},
-    {"text/markdown", "md"},
-    {"video/mp4", "mp4"},
-    {"video/webm", "webm"},
-    {"video/ogg", "ogv"},
-    {"video/mp2t", "ts"},
-    {"audio/mp4", "m4a"},
-    {"audio/aac", "aac"},
-    {"audio/ogg", "oga"},
-    {"audio/opus", "opus"},
-    {"audio/flac", "flac"},
-    {"audio/webm", "weba"},
-    {"application/x-7z-compressed", "7z"},
-    {"application/x-rar-compressed", "rar"},
-    {"application/zstd", "zst"},
-    {"", ""}};
-
 // Reserved (RFC2396)
 #define CIS(c,ch) ( ((unsigned char)(c)) == (ch) )
 #define CHAR_RESERVED(c)  ( CIS(c,';') \
@@ -1951,10 +1918,6 @@ HTSEXT_API const char *infostatuscode_const(int statuscode) {
     return "Requested Range Not Satisfiable";
   case 417:
     return "Expectation Failed";
-  case 429:
-    return "Too Many Requests";
-  case 451:
-    return "Unavailable For Legal Reasons";
   case 500:
     return "Internal Server Error";
   case 501:
@@ -4345,20 +4308,6 @@ void guess_httptype(httrackp * opt, char *s, const char *fil) {
   (void) get_httptype_sized(opt, s, HTS_MIMETYPE_SIZE, fil, 1);
 }
 
-// first match in a NUL-terminated {mime,ext} table. key selects the lookup
-// column (0=mime, 1=ext); returns the other column, or NULL if no row matches
-// (a "*" partner means the row carries no value).
-static const char *hts_mime_lookup(const char *(*table)[2], int key,
-                                   const char *needle) {
-  int j;
-
-  for (j = 0; strnotempty(table[j][1]); j++) {
-    if (strfield2(table[j][key], needle) && table[j][!key][0] != '*')
-      return table[j][!key];
-  }
-  return NULL;
-}
-
 // write the mime type for fil into s (capacity ssize)
 // flag: 1 to always return a type (the "application/..." / octet-stream
 // fallback) returns 1 if a type was written to s, 0 otherwise
@@ -4382,15 +4331,17 @@ HTSEXT_API hts_boolean get_httptype_sized(httrackp *opt, char *s, size_t ssize,
     while ((a > fil) && (*a != '.') && (*a != '/'))
       a--;
     if (a >= fil && *a == '.' && strlen(a) < 32) {
-      const char *mime;
+      int j = 0;
 
       a++;
-      mime = hts_mime_lookup(hts_mime, 1, a);
-      if (mime == NULL)
-        mime = hts_mime_lookup(hts_mime_modern, 1, a);
-      if (mime != NULL) {
-        strlcpybuff(s, mime, ssize);
-        return 1;
+      while(strnotempty(hts_mime[j][1])) {
+        if (strfield2(hts_mime[j][1], a)) {
+          if (hts_mime[j][0][0] != '*') { // a match exists
+            strlcpybuff(s, hts_mime[j][0], ssize);
+            return 1;
+          }
+        }
+        j++;
       }
 
       if (flag) {
@@ -4525,16 +4476,18 @@ int get_userhttptype(httrackp * opt, char *s, const char *fil) {
 // returns 1 if an extension was found (and written to s), 0 otherwise
 int give_mimext(char *s, size_t ssize, const char *st) {
   int ok = 0;
-  const char *ext;
+  int j = 0;
 
   st = hts_effective_mime(st); /* no declared type: derive an html ext */
   s[0] = '\0';
-  ext = hts_mime_lookup(hts_mime, 0, st);
-  if (ext == NULL)
-    ext = hts_mime_lookup(hts_mime_modern, 0, st);
-  if (ext != NULL) {
-    strlcpybuff(s, ext, ssize);
-    ok = 1;
+  while((!ok) && (strnotempty(hts_mime[j][1]))) {
+    if (strfield2(hts_mime[j][0], st)) {
+      if (hts_mime[j][1][0] != '*') { // a match exists
+        strlcpybuff(s, hts_mime[j][1], ssize);
+        ok = 1;
+      }
+    }
+    j++;
   }
   // wrap "x" mimetypes, such as:
   // application/x-mp3
@@ -5801,13 +5754,6 @@ HTSEXT_API int hts_init(void) {
       abortLog("unable to initialize TLS: SSL_CTX_new()");
       assertf("unable to initialize TLS" == NULL);
     }
-    /* Pin a TLS floor (no SSLv3/TLS1.0/1.1); no cert verify, by design. */
-#if OPENSSL_VERSION_NUMBER >= 0x10100000L
-    SSL_CTX_set_min_proto_version(openssl_ctx, TLS1_2_VERSION);
-#else
-    SSL_CTX_set_options(openssl_ctx, SSL_OP_NO_SSLv2 | SSL_OP_NO_SSLv3 |
-                                         SSL_OP_NO_TLSv1 | SSL_OP_NO_TLSv1_1);
-#endif
   }
 #endif
 
@@ -6059,7 +6005,8 @@ HTSEXT_API httrackp *hts_create_opt(void) {
   opt->shell = HTS_FALSE;
   opt->proxy.active = 0;        // pas de proxy
   opt->user_agent_send = HTS_TRUE;
-  StringCopy(opt->user_agent, HTS_DEFAULT_USER_AGENT);
+  StringCopy(opt->user_agent,
+             "Mozilla/4.5 (compatible; HTTrack 3.0x; Windows 98)");
   StringCopy(opt->referer, "");
   StringCopy(opt->from, "");
   opt->savename_83 = HTS_SAVENAME_83_LONG; // long names by default

src/htsrobots.c

@@ -44,84 +44,28 @@ Please visit our Website: http://www.httrack.com
 
 // -- robots --
 
-/* RFC 9309 path-prefix match; '*' any run, '$' anchors end; linear. */
-static hts_boolean robots_pattern_match(const char *pattern, const char *path) {
-  size_t patlen = strlen(pattern);
-  hts_boolean anchored = HTS_FALSE;
-  const char *p, *pend, *s;
-  const char *star = NULL, *star_s = NULL;
-
-  if (patlen > 0 && pattern[patlen - 1] == '$') {
-    anchored = HTS_TRUE;
-    patlen--;
-  }
-  p = pattern;
-  pend = pattern + patlen;
-  s = path;
-  while (*s != '\0') {
-    if (p == pend) {
-      if (!anchored)
-        return HTS_TRUE;  // prefix matched
-      if (star != NULL) { // anchored: '*' must eat the rest
-        p = star + 1;
-        s = ++star_s;
-        continue;
-      }
-      return HTS_FALSE;
-    }
-    if (*p == '*') {
-      star = p++;
-      star_s = s;
-    } else if (*p == *s) {
-      p++;
-      s++;
-    } else if (star != NULL) {
-      p = star + 1;
-      s = ++star_s;
-    } else {
-      return HTS_FALSE;
-    }
-  }
-  while (p < pend && *p == '*')
-    p++;
-  return (p == pend) ? HTS_TRUE : HTS_FALSE;
-}
-
 // fil="" : vérifier si règle déja enregistrée
 int checkrobots(robots_wizard * robots, const char *adr, const char *fil) {
   while(robots) {
     if (strfield2(robots->adr, adr)) {
       if (fil[0]) {
-        /* RFC 9309: longest pattern wins, Allow beats Disallow on ties. */
         int ptr = 0;
-        char line[HTS_ROBOTS_TOKEN_SIZE];
-        size_t toklen = strlen(robots->token);
-        size_t best_len = 0;
-        hts_boolean matched = HTS_FALSE;
-        hts_boolean best_allow = HTS_FALSE;
+        char line[250];
 
-        while (ptr < (int) toklen) {
-          ptr += binput(robots->token + ptr, line, sizeof(line) - 1);
-          if (line[0] != 'A' && line[0] != 'D')
-            continue;
-          {
-            const hts_boolean is_allow =
-                (line[0] == 'A') ? HTS_TRUE : HTS_FALSE;
-            const char *pat = line + 1;
-
-            if (robots_pattern_match(pat, fil)) {
-              const size_t len = strlen(pat);
-
-              if (!matched || len > best_len || (len == best_len && is_allow)) {
-                matched = HTS_TRUE;
-                best_len = len;
-                best_allow = is_allow;
+        if (strnotempty(robots->token)) {
+          do {
+            ptr += binput(robots->token + ptr, line, 200);
+            if (line[0] == '/') {       // absolu
+              if (strfield(fil, line)) {        // commence avec ligne
+                return -1;      // interdit
+              }
+            } else {            // relatif
+              if (strstrcase(fil, line)) {
+                return -1;
               }
             }
-          }
+          } while((strnotempty(line)) && (ptr < (int) strlen(robots->token)));
         }
-        if (matched && !best_allow)
-          return -1; // forbidden
       } else {
         return -1;
       }
@@ -130,93 +74,6 @@ int checkrobots(robots_wizard * robots, const char *adr, const char *fil) {
   }
   return 0;
 }
-
-/* Append "<marker><pattern>\n" to the bounded rule blob if it fits. */
-static void robots_blob_add(char *blob, size_t blobsize, char marker,
-                            const char *pat) {
-  const size_t used = strlen(blob);
-  const size_t need = strlen(pat) + 2; // marker + '\n'
-
-  if (need < blobsize - used) { // overflow-safe: used <= blobsize-1
-    blob[used] = marker;
-    blob[used + 1] = '\0';
-    strlcatbuff(blob, pat, blobsize);
-    strlcatbuff(blob, "\n", blobsize);
-  }
-}
-
-void robots_parse(robots_wizard *robots, const char *adr, const char *body,
-                  size_t bodysize, char *info, size_t infosize,
-                  hts_boolean keep_root_disallow) {
-  size_t bptr = 0;
-  int record = 0;
-  char BIGSTK line[1024];
-  char BIGSTK blob[HTS_ROBOTS_TOKEN_SIZE];
-
-  blob[0] = '\0';
-  if (info != NULL && infosize > 0)
-    info[0] = '\0';
-#if DEBUG_ROBOTS
-  printf("robots.txt dump:\n%s\n", body);
-#endif
-  while (bptr < bodysize) {
-    char *comm;
-    int llen;
-
-    bptr += binput(body + bptr, line, sizeof(line) - 2);
-    comm = strchr(line, '#'); // strip comment
-    if (comm != NULL)
-      *comm = '\0';
-    llen = (int) strlen(line); // strip trailing spaces
-    while (llen > 0 && is_realspace(line[llen - 1])) {
-      line[llen - 1] = '\0';
-      llen--;
-    }
-    if (strfield(line, "user-agent:")) {
-      char *a = line + 11;
-
-      while (is_realspace(*a))
-        a++;
-      if (*a == '*') {
-        if (record != 2)
-          record = 1; // generic group applies to us
-      } else if (strfield(a, "httrack") || strfield(a, "winhttrack") ||
-                 strfield(a, "webhttrack")) {
-        blob[0] = '\0'; // explicit group: restart capture
-        if (info != NULL && infosize > 0)
-          info[0] = '\0';
-        record = 2; // locked to the httrack group
-      } else
-        record = 0;
-    } else if (record) {
-      hts_boolean is_allow = strfield(line, "allow:");
-      hts_boolean is_disallow = !is_allow && strfield(line, "disallow:");
-
-      if (is_allow || is_disallow) {
-        char *a = line + (is_allow ? 6 : 9);
-
-        while (is_realspace(*a))
-          a++;
-        if (strnotempty(a)) {
-          if (is_disallow && !keep_root_disallow && strcmp(a, "/") == 0) {
-            // dropped: site-wide disallow ignored by option
-          } else {
-            robots_blob_add(blob, sizeof(blob), is_allow ? 'A' : 'D', a);
-            if (is_disallow && info != NULL &&
-                strlen(a) + 2 < infosize - strlen(info)) {
-              if (strnotempty(info))
-                strlcatbuff(info, ", ", infosize);
-              strlcatbuff(info, a, infosize);
-            }
-          }
-        }
-      }
-    }
-  }
-  if (strnotempty(blob))
-    checkrobots_set(robots, adr, blob);
-}
-
 int checkrobots_set(robots_wizard * robots, const char *adr, const char *data) {
   if (((int) strlen(adr)) >= sizeof(robots->adr) - 2)
     return 0;

src/htsrobots.h

@@ -39,27 +39,17 @@ Please visit our Website: http://www.httrack.com
 #define HTS_DEF_FWSTRUCT_robots_wizard
 typedef struct robots_wizard robots_wizard;
 #endif
-
-/* Per-host blob: one rule per line, first byte 'A'/'D' then path pattern. */
-#define HTS_ROBOTS_TOKEN_SIZE 4096
-
 struct robots_wizard {
   char adr[128];
-  char token[HTS_ROBOTS_TOKEN_SIZE];
+  char token[4096];
   struct robots_wizard *next;
 };
 
 /* Library internal definictions */
 #ifdef HTS_INTERNAL_BYTECODE
-/* -1 if `fil` disallowed for `adr` (RFC 9309); empty: -1 if rules exist. */
 int checkrobots(robots_wizard * robots, const char *adr, const char *fil);
 void checkrobots_free(robots_wizard * robots);
 int checkrobots_set(robots_wizard * robots, const char *adr, const char *data);
-/* Parse robots.txt `body` for `adr`, storing the HTTrack group's rules; `info`
-   gets a disallow summary, `keep_root_disallow` FALSE drops "Disallow: /". */
-void robots_parse(robots_wizard *robots, const char *adr, const char *body,
-                  size_t bodysize, char *info, size_t infosize,
-                  hts_boolean keep_root_disallow);
 #endif
 
 #endif

src/htsselftest.c

@@ -239,14 +239,6 @@ static void basic_selftests(void) {
     assertf(strcmp(ext, "html") == 0);
     assertf(give_mimext(ext, sizeof(ext), "no/such-mime-type") == 0);
     assertf(ext[0] == '\0');
-    // modern web formats -> extension. Avoid MIME types the
-    // application/<=4-char-subtype fallback could fabricate without a row.
-    assertf(give_mimext(ext, sizeof(ext), "image/webp") == 1);
-    assertf(strcmp(ext, "webp") == 0);
-    assertf(give_mimext(ext, sizeof(ext), "application/manifest+json") == 1);
-    assertf(strcmp(ext, "webmanifest") == 0);
-    assertf(give_mimext(ext, sizeof(ext), "font/woff2") == 1);
-    assertf(strcmp(ext, "woff2") == 0);
   }
   // convtolower(): lower-cases into the caller buffer (bounded by its size).
   {
@@ -301,16 +293,6 @@ static void basic_selftests(void) {
     assertf(get_httptype_sized(opt, r.contenttype, sizeof(r.contenttype),
                                "x.gif", 0) == 1);
     assertf(strcmp(r.contenttype, "image/gif") == 0);
-    // modern extensions map back to their MIME type
-    assertf(get_httptype_sized(opt, r.contenttype, sizeof(r.contenttype),
-                               "x.webp", 0) == 1);
-    assertf(strcmp(r.contenttype, "image/webp") == 0);
-    assertf(get_httptype_sized(opt, r.contenttype, sizeof(r.contenttype),
-                               "app.wasm", 0) == 1);
-    assertf(strcmp(r.contenttype, "application/wasm") == 0);
-    assertf(get_httptype_sized(opt, r.contenttype, sizeof(r.contenttype),
-                               "mod.mjs", 0) == 1);
-    assertf(strcmp(r.contenttype, "text/javascript") == 0);
     // no extension and flag==0: nothing written, returns 0
     assertf(get_httptype_sized(opt, r.contenttype, sizeof(r.contenttype),
                                "noextfile", 0) == 0);
@@ -1302,123 +1284,6 @@ static int st_urlhack(httrackp *opt, int argc, char **argv) {
   return 0;
 }
 
-/* Default User-Agent: honest HTTrack token, no resurrected Windows 98. */
-static int st_useragent(httrackp *opt, int argc, char **argv) {
-  const char *ua = StringBuff(opt->user_agent);
-  (void) argc;
-  (void) argv;
-  assertf(ua != NULL);
-  assertf(strcmp(ua, HTS_DEFAULT_USER_AGENT) == 0);
-  /* Teeth independent of the macro: honest token + self-identifier, and no
-     legacy Mozilla/4.x fake-browser string (rejects the whole relic family). */
-  assertf(strstr(ua, "HTTrack/") != NULL);
-  assertf(strstr(ua, "+https://www.httrack.com/") != NULL);
-  assertf(strstr(ua, "Mozilla/4.") == NULL);
-  printf("useragent self-test OK: %s\n", ua);
-  return 0;
-}
-
-/* HTTP status code -> reason phrase, including the modern 429/451. */
-static int st_status(httrackp *opt, int argc, char **argv) {
-  const char *s;
-  (void) opt;
-  (void) argc;
-  (void) argv;
-  s = infostatuscode_const(429);
-  assertf(s != NULL && strcmp(s, "Too Many Requests") == 0);
-  s = infostatuscode_const(451);
-  assertf(s != NULL && strcmp(s, "Unavailable For Legal Reasons") == 0);
-  /* A spot-check of a long-standing code, and an unknown one. */
-  s = infostatuscode_const(404);
-  assertf(s != NULL && strcmp(s, "Not Found") == 0);
-  assertf(infostatuscode_const(799) == NULL);
-  printf("status self-test OK\n");
-  return 0;
-}
-
-/* Each call parses `txt` under a fresh host, then checkrobots() for `path`. */
-static int rb_decide(robots_wizard *r, const char *txt, const char *path) {
-  static int n = 0;
-  char host[64];
-
-  snprintf(host, sizeof(host), "h%d.example", n++);
-  robots_parse(r, host, txt, strlen(txt), NULL, 0, HTS_TRUE);
-  return checkrobots(r, host, path);
-}
-
-static int st_robots(httrackp *opt, int argc, char **argv) {
-  robots_wizard robots;
-  (void) opt;
-  (void) argc;
-  (void) argv;
-  memset(&robots, 0, sizeof(robots));
-
-  /* Longer Allow re-opens subtree under Disallow: / (old matcher couldn't). */
-  {
-    const char *txt = "User-agent: *\nDisallow: /\nAllow: /public/\n";
-
-    assertf(rb_decide(&robots, txt, "/public/x") == 0); /* allowed */
-    assertf(rb_decide(&robots, txt, "/private") == -1); /* denied */
-    assertf(rb_decide(&robots, txt, "/") == -1);        /* denied */
-  }
-
-  /* Equal-length match: Allow wins the tie over Disallow. */
-  {
-    const char *txt = "User-agent: *\nDisallow: /foo\nAllow: /foo\n";
-
-    assertf(rb_decide(&robots, txt, "/foo/bar") == 0);
-  }
-
-  /* Longest match wins even when it is not the last rule. */
-  {
-    assertf(rb_decide(&robots, "User-agent: *\nDisallow: /a/b\nAllow: /a\n",
-                      "/a/b/c") == -1);
-    assertf(rb_decide(&robots, "User-agent: *\nAllow: /a/b\nDisallow: /a\n",
-                      "/a/b/c") == 0);
-  }
-
-  /* '*' matches any run of characters. */
-  {
-    const char *txt = "User-agent: *\nDisallow: /*.php\n";
-
-    assertf(rb_decide(&robots, txt, "/a/b/index.php") == -1);
-    assertf(rb_decide(&robots, txt, "/a/b/index.html") == 0);
-  }
-
-  /* Trailing '$' anchors the end of the path. */
-  {
-    const char *txt = "User-agent: *\nDisallow: /a$\n";
-
-    assertf(rb_decide(&robots, txt, "/a") == -1);
-    assertf(rb_decide(&robots, txt, "/ab") == 0);
-    assertf(rb_decide(&robots, txt, "/a/b") == 0);
-  }
-
-  /* The httrack-specific group replaces the generic '*' group entirely. */
-  {
-    const char *txt = "User-agent: *\nDisallow: /everyone\n"
-                      "User-agent: httrack\nDisallow: /\n";
-
-    assertf(rb_decide(&robots, txt, "/anything") == -1);
-  }
-
-  /* Replace, not merge: the generic group does not bind the httrack group. */
-  {
-    const char *txt = "User-agent: *\nDisallow: /x\n"
-                      "User-agent: httrack\nDisallow: /y\n";
-
-    assertf(rb_decide(&robots, txt, "/x") == 0);
-    assertf(rb_decide(&robots, txt, "/y") == -1);
-  }
-
-  /* No rules: everything is allowed. */
-  assertf(rb_decide(&robots, "User-agent: *\nDisallow:\n", "/x") == 0);
-
-  checkrobots_free(&robots);
-  printf("robots self-test OK\n");
-  return 0;
-}
-
 /* ------------------------------------------------------------ */
 /* Registry: name -> handler, with a usage hint and a one-line description. */
 /* ------------------------------------------------------------ */
@@ -1465,10 +1330,6 @@ static const struct selftest_entry {
      st_cache_writefail},
     {"dns", "", "DNS resolver/cache self-test", st_dns},
     {"cookies", "", "cookie request-header self-test", st_cookies},
-    {"useragent", "", "default User-Agent self-test", st_useragent},
-    {"status", "", "HTTP status code -> reason phrase self-test", st_status},
-    {"robots", "", "robots.txt RFC 9309 Allow/Disallow precedence self-test",
-     st_robots},
 };
 
 static void list_selftests(void) {

src/htsserver.c

@@ -358,12 +358,12 @@ int smallserver(T_SOC soc, char *url, char *method, char *data, char *path) {
       {NULL, 0}
     };
     initStrElt initStr[] = {
-        {"user", HTS_DEFAULT_USER_AGENT},
-        {"footer", "<!-- Mirrored from %s%s by HTTrack Website Copier/3.x "
-                   "[XR&CO'2014], %s -->"},
-        {"url2",
-         "+*.png +*.gif +*.jpg +*.jpeg +*.css +*.js -ad.doubleclick.net/*"},
-        {NULL, NULL}};
+      {"user", "Mozilla/4.5 (compatible; HTTrack 3.0x; Windows 98)"},
+      {"footer",
+       "<!-- Mirrored from %s%s by HTTrack Website Copier/3.x [XR&CO'2014], %s -->"},
+      {"url2", "+*.png +*.gif +*.jpg +*.jpeg +*.css +*.js -ad.doubleclick.net/*"},
+      {NULL, NULL}
+    };
     int i = 0;
 
     for(i = 0; initInt[i].name; i++) {

src/htswizard.c

@@ -80,10 +80,6 @@ htspair_t hts_detect_embed[] = {
   {NULL, NULL}
 };
 
-/* HTML5 media siblings of <img src>: same near-link treatment (#451) */
-static const htspair_t hts_detect_embed_html5[] = {
-    {"source", "src"}, {"source", "srcset"}, {"track", "src"}, {NULL, NULL}};
-
 /* Internal */
 static int hts_acceptlink_(httrackp * opt, int ptr, const char *adr,
                            const char *fil, const char *tag,
@@ -140,17 +136,6 @@ static int cmp_token(const char *tag, const char *cmp) {
           && !isalnum((unsigned char) tag[p]));
 }
 
-/* TRUE if (tag, attribute) matches an embedded-asset pair in the table */
-static hts_boolean is_embed_pair(const htspair_t *table, const char *tag,
-                                 const char *attribute) {
-  int i;
-  for (i = 0; table[i].tag != NULL; i++) {
-    if (cmp_token(tag, table[i].tag) && cmp_token(attribute, table[i].attr))
-      return HTS_TRUE;
-  }
-  return HTS_FALSE;
-}
-
 static int hts_acceptlink_(httrackp * opt, int ptr,
                            const char *adr, const char *fil, const char *tag,
                            const char *attribute, int *set_prio_to,
@@ -178,9 +163,15 @@ static int hts_acceptlink_(httrackp * opt, int ptr,
 
   /* Built-in known tags (<img src=..>, ..) */
   if (forbidden_url != 0 && opt->nearlink && tag != NULL && attribute != NULL) {
-    if (is_embed_pair(hts_detect_embed, tag, attribute) ||
-        is_embed_pair(hts_detect_embed_html5, tag, attribute)) {
-      embedded_triggered = 1;
+    int i;
+
+    for(i = 0; hts_detect_embed[i].tag != NULL; i++) {
+      if (cmp_token(tag, hts_detect_embed[i].tag)
+          && cmp_token(attribute, hts_detect_embed[i].attr)
+        ) {
+        embedded_triggered = 1;
+        break;
+      }
     }
   }
 

src/proxy/proxytrack.c

@@ -497,12 +497,6 @@ static const char *GetHttpMessage(int statuscode) {
   case 417:
     return "Expectation Failed";
     break;
-  case 429:
-    return "Too Many Requests";
-    break;
-  case 451:
-    return "Unavailable For Legal Reasons";
-    break;
   case 500:
     return "Internal Server Error";
     break;

tests/01_engine-parse.test

@@ -323,33 +323,4 @@ grep -Fq 'href="ahref%20(4).gif"' "$saved9" ||
 ! grep -Eq '(src|href)="[^"]*%28' "$saved9" ||
     ! echo "FAIL #163: gate over-fired onto a non-url() attribute link" || exit 1
 
-# HTML5 <source>/<track> follow as embedded near-links past the -r2 depth boundary (#451).
-# img.gif positive control; plain.gif (bare <a href>) negative control proves the gate is selective.
-site10="$tmp/html5media"
-mkdir -p "$site10"
-for f in img ss plain; do gif "$site10/$f.gif"; done
-printf 'x' >"$site10/v.webm"
-printf 'x' >"$site10/subs.vtt"
-cat >"$site10/index.html" <<EOF
-<html><body><a href="leaf.html">leaf</a></body></html>
-EOF
-cat >"$site10/leaf.html" <<EOF
-<html><body>
-<img src="img.gif">
-<picture><source srcset="ss.gif 2x"></picture>
-<video><source src="v.webm"></video>
-<video><track src="subs.vtt"></video>
-<a href="plain.gif">plain link past the boundary</a>
-</body></html>
-EOF
-out10="$tmp/html5media-out"
-rm -rf "$out10"
-mkdir -p "$out10"
-httrack "file://$site10/index.html" -O "$out10" --quiet --near -r2 >"$out10/.log" 2>&1 || true
-found "img.gif" "$out10"
-found "ss.gif" "$out10"
-found "v.webm" "$out10"
-found "subs.vtt" "$out10"
-notfound "plain.gif" "$out10"
-
 exit 0

tests/01_engine-robots.test

@@ -1,7 +0,0 @@
-#!/bin/bash
-#
-
-set -euo pipefail
-
-# robots.txt RFC 9309 Allow/Disallow precedence (#452): longest match wins.
-httrack -O /dev/null -#test=robots run | grep -q "robots self-test OK"

tests/01_engine-status.test

@@ -1,7 +0,0 @@
-#!/bin/bash
-#
-
-set -euo pipefail
-
-# HTTP status -> reason phrase, including the modern 429/451 (#453).
-httrack -O /dev/null -#test=status run | grep -q "status self-test OK"

tests/01_engine-useragent.test

@@ -1,7 +0,0 @@
-#!/bin/bash
-#
-
-set -euo pipefail
-
-# Default User-Agent (#449): honest HTTrack token, no Windows 98 relic.
-httrack -O /dev/null -#test=useragent run | grep -q "useragent self-test OK"

tests/Makefile.am

@@ -44,15 +44,12 @@ TESTS = \
 	01_engine-pause.test \
 	01_engine-rcfile.test \
 	01_engine-relative.test \
-	01_engine-robots.test \
 	01_engine-savename.test \
 	01_engine-selftest-dispatch.test \
 	01_engine-simplify.test \
-	01_engine-status.test \
 	01_engine-stripquery.test \
 	01_engine-strsafe.test \
 	01_engine-urlhack.test \
-	01_engine-useragent.test \
 	02_manpage-regen.test \
 	02_update-cache.test \
 	10_crawl-simple.test \